-
Notifications
You must be signed in to change notification settings - Fork 362
Bump vsce from 2.15.0 to 2.32.0, switch TS to ESM import when possible #2602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@microsoft-github-policy-service agree company="NVIDIA" |
|
Looks like that bumped some other ESLint deps which don't like some of the |
d37f73c to
332d0f8
Compare
|
Moved as many remaining imports using CJS syntax ( https://github.com/Azure/Azurite/blob/v3.35.0/src/common/utils/utils.ts#L8-L10 |
|
Hmm 446 passing (6s)
1 pending
4 failing
1) table Entity APIs test
Service with mismatching cors rules should response header Vary @loki:
AssertionError [ERR_ASSERTION]: false == true
+ expected - actual
-false
+true
at Context.<anonymous> (tests/table/auth/tableCorsRequest.test.ts:494:12)
at processTicksAndRejections (node:internal/process/task_queues:105:5)
2) table Entity APIs test
Request Match rule exists that allows all origins (*) @loki:
AssertionError [ERR_ASSERTION]: false == true
+ expected - actual
-false
+true
at Context.<anonymous> (tests/table/auth/tableCorsRequest.test.ts:527:12)
at processTicksAndRejections (node:internal/process/task_queues:105:5)
3) table Entity APIs test
Request Match rule exists for exact origin @loki:
AssertionError [ERR_ASSERTION]: false == true
+ expected - actual
-false
+true
at Context.<anonymous> (tests/table/auth/tableCorsRequest.test.ts:564:12)
at processTicksAndRejections (node:internal/process/task_queues:105:5)
4) table Entity APIs test
Request Match rule in sequence @loki:
AssertionError [ERR_ASSERTION]: false == true
+ expected - actual
-false
+true
at Context.<anonymous> (tests/table/auth/tableCorsRequest.test.ts:646:12)
at processTicksAndRejections (node:internal/process/task_queues:105:5)Since none of the CORS logic on Azurite's side changed, it seems like the VSCE bump pulling in a newer |
|
This is also a bit awkward because some of the updated Azure SDK packages now declare Node.js 20 as a minimum, so the Node.js 16 tests will fail. That means we need #2568 first to drop Node.js 16. |
|
It doesn't look like
|
|
It's this commit for Azure/azure-sdk-for-js@5e0ed69 It's first included in the Since bumping VSCE to 2.32.0 also bumps Switching the operation options to stop ignoring unknown properties doesn't help either. serviceClientWithOrigin.getProperties({
serializerOptions: {
ignoreUnknownProperties: false,
xml: {}
}
})@blueww @EmmaZhu Am I good to remove these 4 CORS unit tests? |
332d0f8 to
df2b9e1
Compare
df2b9e1 to
f7b5013
Compare
Relates to #2601.
vscemigrated to@vscode/vscestarting with 2.16.0.microsoft/vscode-vsce@0383324