Skip to content

Conversation

@evelyn-ys
Copy link
Member

@evelyn-ys evelyn-ys commented Jun 9, 2025

This PR removes msrestazure usage from the acrssc extension so that we can finally drop msrestazure dependency from cli core Azure/azure-cli#31066


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 9, 2025 06:05
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 9, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 9, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A concise description of the purpose of the PR, followed by summarized bullets of changes

  • Remove dependency on msrestazure by replacing CloudError with HttpResponseError
  • Bump extension version to 1.0.0b3
  • Add release notes entry for 1.0.0b3

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/acrcssc/setup.py Updated version from 1.0.0b2 to 1.0.0b3
src/acrcssc/azext_acrcssc/helper/_workflow_status.py Replaced msrestazure.azure_exceptions.CloudError with azure.core.exceptions.HttpResponseError
src/acrcssc/HISTORY.rst Added 1.0.0b3 entry describing the removal of msrestazure dependency
Comments suppressed due to low confidence (2)

src/acrcssc/azext_acrcssc/helper/_workflow_status.py:242

  • [nitpick] Consider adding or updating unit tests to cover the new HttpResponseError branches in process_taskrun to ensure error handling works as expected.
except HttpResponseError as e:

src/acrcssc/setup.py:16

  • The PR title and changelog note indicate removing msrestazure, but setup.py still lists it in install_requires. Please remove msrestazure from the dependencies.
VERSION = '1.0.0b3'

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

@yonzhan yonzhan requested a review from jiasli June 9, 2025 07:30
@evelyn-ys evelyn-ys merged commit 8e16213 into Azure:main Jun 10, 2025
26 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ acrcssc-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126783128&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants