-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{Acrssc} Remove msrestazure dependency #8841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
A concise description of the purpose of the PR, followed by summarized bullets of changes
- Remove dependency on
msrestazureby replacingCloudErrorwithHttpResponseError - Bump extension version to 1.0.0b3
- Add release notes entry for 1.0.0b3
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/acrcssc/setup.py | Updated version from 1.0.0b2 to 1.0.0b3 |
| src/acrcssc/azext_acrcssc/helper/_workflow_status.py | Replaced msrestazure.azure_exceptions.CloudError with azure.core.exceptions.HttpResponseError |
| src/acrcssc/HISTORY.rst | Added 1.0.0b3 entry describing the removal of msrestazure dependency |
Comments suppressed due to low confidence (2)
src/acrcssc/azext_acrcssc/helper/_workflow_status.py:242
- [nitpick] Consider adding or updating unit tests to cover the new
HttpResponseErrorbranches inprocess_taskrunto ensure error handling works as expected.
except HttpResponseError as e:
src/acrcssc/setup.py:16
- The PR title and changelog note indicate removing
msrestazure, butsetup.pystill lists it ininstall_requires. Please removemsrestazurefrom the dependencies.
VERSION = '1.0.0b3'
|
|
[Release] Update index.json for extension [ acrcssc-1.0.0b3 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126783128&view=results |
This PR removes msrestazure usage from the acrssc extension so that we can finally drop msrestazure dependency from cli core Azure/azure-cli#31066
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.