Skip to content

Conversation

@evelyn-ys
Copy link
Member

To support Azure/azure-cli#31066


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 10, 2025 07:46
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 10, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 10, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the msrestazure dependency by switching imports, bumping the version, and updating the changelog.

  • Bump extension version from 2.0.0b1 to 2.0.0b2
  • Replace msrestazure.tools import with azure.mgmt.core.tools
  • Add a HISTORY entry noting the removed dependency

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/aosm/setup.py Updated VERSION to 2.0.0b2
src/aosm/azext_aosm/_validators.py Switched import from msrestazure.tools to azure.mgmt.core.tools
src/aosm/HISTORY.rst Added 2.0.0b2 release entry and changelog note
Comments suppressed due to low confidence (2)

src/aosm/HISTORY.rst:6

  • The underline length for the RST heading '2.0.0b2' should match the heading text length (7 characters). Adjust the underline to seven plus signs to comply with RST formatting.
++++++++

src/aosm/azext_aosm/_validators.py:12

  • [nitpick] Consider adding or updating unit tests for example_name_or_id_validator to confirm it correctly handles both resource names and resource IDs after switching the import source.
from azure.mgmt.core.tools import is_valid_resource_id, resource_id

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

@yonzhan yonzhan requested a review from jiasli June 10, 2025 09:03
- AZURECLI/2.56.0 azsdk-python-azure-mgmt-resource/23.1.0b2 Python/3.8.10 (Linux-5.15.146.1-microsoft-standard-WSL2-x86_64-with-glibc2.29)
method: HEAD
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_cnf_nfd_000001?api-version=2022-09-01
uri: https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/resourcegroups/cli_test_cnf_nfd_000001?api-version=2024-11-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No SDK is bumped by this PR but API version is updated. Does this mean the recording file is already invalid?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I saw this request is from azure-mgmt-resource required by main Azure CLI.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. It's using some basic APIs (from resource module/vm module/network module/storage module) whose API version have been bumped in main repo

@evelyn-ys evelyn-ys merged commit ec44aab into Azure:main Jun 11, 2025
23 of 24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aosm-2.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126927700&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants