-
Notifications
You must be signed in to change notification settings - Fork 1.5k
{netappfiles-preview} Remove msrestazure for netappfiles-preview #8849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{netappfiles-preview} Remove msrestazure for netappfiles-preview #8849
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the netappfiles-preview extension to remove the msrestazure dependency and bumps the version accordingly.
- Updated version in setup.py from 1.0.0b3 to 1.0.0b4.
- Removed the CloudError exception handling related to the msrestazure dependency in _exception_handler.py.
- Updated the HISTORY.rst file to reflect the dependency removal and version update.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/netappfiles-preview/setup.py | Updated version to match the removal of msrestazure dependency. |
| src/netappfiles-preview/azext_netappfiles_preview/_exception_handler.py | Removed CloudError handling due to the removal of msrestazure. |
| src/netappfiles-preview/HISTORY.rst | Updated history with the new version and dependency removal note. |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
@microsoft-github-policy-service rerun |
|
[Release] Update index.json for extension [ netappfiles-preview-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126929339&view=results |
To support Azure/azure-cli#31066
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.