Skip to content

Conversation

@Jing-song
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az mesh
aaz: Azure/aaz#784

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 18, 2025 07:34
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 18, 2025

❌Azure CLI Extensions Breaking Change Test
❌mesh
rule cmd_name rule_message suggest_message
1008 - ParaPropAdd mesh volume list cmd mesh volume list update parameter resource_group: added property required=True please remove property required=True for parameter resource_group of cmd mesh volume list

@azure-client-tools-bot-prd
Copy link

Hi @Jing-song,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Service Fabric Mesh commands to the new AAZ command structure, removing AutoRest‐generated model files and updating command implementations. Key changes include the removal of legacy models and client factory methods, updates to custom command implementations (e.g. create_volume and secret_show), and revisions of command group definitions and help texts.

Reviewed Changes

Copilot reviewed 130 out of 130 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/mesh/azext_mesh/servicefabricmesh/mgmt/servicefabricmesh/models/application_properties.py Removed auto-generated model for application properties.
src/mesh/azext_mesh/servicefabricmesh/mgmt/servicefabricmesh/models/add_remove_replica_scaling_mechanism.py Removed legacy scaling mechanism model.
src/mesh/azext_mesh/servicefabricmesh/mgmt/servicefabricmesh/models/init.py Removed aggregation of auto-generated models.
src/mesh/azext_mesh/servicefabricmesh/mgmt/servicefabricmesh/init.py Removed legacy client initializations.
src/mesh/azext_mesh/servicefabricmesh/mgmt/init.py Removed legacy management module initializations.
src/mesh/azext_mesh/servicefabricmesh/init.py Removed legacy namespace declaration for Service Fabric Mesh.
src/mesh/azext_mesh/custom.py Updated custom operations to incorporate ArgumentUsageError and new AAZ command calls.
src/mesh/azext_mesh/commands.py Revised command group definitions to align with the new AAZ command implementations.
src/mesh/azext_mesh/azext_metadata.json Updated minimum CLI Core version requirement.
src/mesh/azext_mesh/aaz/latest/mesh/volume/_show.py Updated property initialization to match the new AAZ type patterns.
src/mesh/azext_mesh/aaz/latest/mesh/volume/_list.py Removed legacy list operation by subscription and adjusted required argument schemas.
src/mesh/azext_mesh/aaz/latest/mesh/volume/_create.py Introduced a new AAZ command for creating volumes with updated content serialization.
src/mesh/azext_mesh/aaz/latest/mesh/volume/init.py Aggregated new volume command modules.
src/mesh/azext_mesh/aaz/latest/mesh/secretvalue/_show.py Introduced a new AAZ command for showing secret values.
src/mesh/azext_mesh/aaz/latest/mesh/secretvalue/_listvalue.py Introduced a new AAZ command for listing secret values.
src/mesh/azext_mesh/aaz/latest/mesh/secretvalue/init.py Aggregated new secretvalue command modules.
src/mesh/azext_mesh/aaz/latest/init.py Added namespace initialization for new AAZ commands.
src/mesh/azext_mesh/_help.py Removed outdated help entries in favor of new AAZ command help defined elsewhere.
src/mesh/azext_mesh/_client_factory.py Removed unused client factory methods corresponding to removed APIs.
src/mesh/HISTORY.rst Updated release history to document the migration to the new AAZ commands.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

@yonzhan yonzhan requested a review from kairu-ms June 18, 2025 08:53
@yonzhan yonzhan requested a review from jsntcy June 18, 2025 08:54
@evelyn-ys evelyn-ys merged commit fda59f6 into Azure:main Jun 18, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ mesh-1.0.0b2 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127647128&view=results

@evelyn-ys
Copy link
Member

Follow-up fo Azure/azure-cli#31066

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants