-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Notification-hub] Remove az notification-hub test-send command
#8877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @Jing-song, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated "az notification-hub test-send" command and associated code from the extension. It eliminates the related vendor SDK models, custom command implementations, validator functions, parameter definitions, help texts, and test recordings while updating the metadata version accordingly.
- Removed generated model files that are no longer needed.
- Deleted the custom send notification function, command registration, and associated validators.
- Updated API version in test recordings and bumped the minimum CLI core version.
Reviewed Changes
Copilot reviewed 81 out of 81 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/notification-hub/azext_notification_hub/vendored_sdks/models/*.py | Removed unused, auto-generated model files. |
| src/notification-hub/azext_notification_hub/custom.py | Deleted the debug_send_notificationhubs_hub function. |
| src/notification-hub/azext_notification_hub/commands.py | Removed the "test-send" command registration. |
| src/notification-hub/azext_notification_hub/_validators.py | Deleted unused validator for test-send. |
| src/notification-hub/azext_notification_hub/_params.py | Cleared the parameters context for test-send. |
| src/notification-hub/azext_notification_hub/_help.py | Removed help text for the test-send command. |
| src/notification-hub/azext_notification_hub/_client_factory.py | Removed client factory code no longer in use. |
| src/notification-hub/azext_notification_hub/init.py | Adjusted initialization to remove de-referenced factories. |
| src/notification-hub/HISTORY.rst | Updated the history with a new beta version entry. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
|
||
| 1.0.0b2 | ||
| ++++++ | ||
| * Remove `az notification-hub test-send` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to upgrade the major version as it's a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
|
Hi @Jing-song
|
|
Follow-up fo Azure/azure-cli#31066 |
|
[Release] Update index.json for extension [ notification-hub-2.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127650073&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.