Skip to content

Conversation

@Jing-song
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings June 18, 2025 09:52
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 18, 2025

❌Azure CLI Extensions Breaking Change Test
❌notification-hub
rule cmd_name rule_message suggest_message
1002 - CmdRemove notification-hub test-send cmd notification-hub test-send removed please confirm cmd notification-hub test-send removed

@azure-client-tools-bot-prd
Copy link

Hi @Jing-song,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 18, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated "az notification-hub test-send" command and associated code from the extension. It eliminates the related vendor SDK models, custom command implementations, validator functions, parameter definitions, help texts, and test recordings while updating the metadata version accordingly.

  • Removed generated model files that are no longer needed.
  • Deleted the custom send notification function, command registration, and associated validators.
  • Updated API version in test recordings and bumped the minimum CLI core version.

Reviewed Changes

Copilot reviewed 81 out of 81 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/notification-hub/azext_notification_hub/vendored_sdks/models/*.py Removed unused, auto-generated model files.
src/notification-hub/azext_notification_hub/custom.py Deleted the debug_send_notificationhubs_hub function.
src/notification-hub/azext_notification_hub/commands.py Removed the "test-send" command registration.
src/notification-hub/azext_notification_hub/_validators.py Deleted unused validator for test-send.
src/notification-hub/azext_notification_hub/_params.py Cleared the parameters context for test-send.
src/notification-hub/azext_notification_hub/_help.py Removed help text for the test-send command.
src/notification-hub/azext_notification_hub/_client_factory.py Removed client factory code no longer in use.
src/notification-hub/azext_notification_hub/init.py Adjusted initialization to remove de-referenced factories.
src/notification-hub/HISTORY.rst Updated the history with a new beta version entry.

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey


1.0.0b2
++++++
* Remove `az notification-hub test-send`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need to upgrade the major version as it's a breaking change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@github-actions
Copy link

github-actions bot commented Jun 18, 2025

Hi @Jing-song

⚠️ Release Requirements

Module: notification-hub

  • ⚠️ Please update VERSION to be 1.0.0b2 in src/notification-hub/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 18, 2025
@evelyn-ys evelyn-ys removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 18, 2025
@evelyn-ys evelyn-ys merged commit e18297e into Azure:main Jun 18, 2025
33 of 36 checks passed
@evelyn-ys
Copy link
Member

Follow-up fo Azure/azure-cli#31066

@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ notification-hub-2.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=127650073&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants