Skip to content

Conversation

@tundwed
Copy link
Member

@tundwed tundwed commented Jan 7, 2026

  • Upgrade to API version 2025-12-01-preview
  • Remove add-attachment and delete-attachment commands (no longer supported in new API)

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

{edge-action}

General Guidelines

  • [x ] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [ x] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [x ] My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

- Upgrade to API version 2025-12-01-preview
- Remove add-attachment and delete-attachment commands (no longer supported in new API)
- Retain custom fixes for get-version-code and swap-default commands
Copilot AI review requested due to automatic review settings January 7, 2026 19:15
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 7, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR claims to upgrade the edge-action extension to API version 2025-12-01-preview and removes the add-attachment and delete-attachment commands that are no longer supported in the new API version. The extension version is bumped from 1.0.0b2 to 1.0.0b3.

Key Changes:

  • Version incremented to 1.0.0b3
  • Removed add-attachment and delete-attachment command implementations
  • Updated imports to exclude deleted command modules

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/edge-action/setup.py Bumps extension version from 1.0.0b2 to 1.0.0b3
src/edge-action/HISTORY.rst Adds changelog entry for version 1.0.0b3 documenting API upgrade and command removals
src/edge-action/azext_edge_action/aaz/latest/edge_action/_add_attachment.py Removes add-attachment command implementation (entire file deleted)
src/edge-action/azext_edge_action/aaz/latest/edge_action/_delete_attachment.py Removes delete-attachment command implementation (entire file deleted)
src/edge-action/azext_edge_action/aaz/latest/edge_action/init.py Removes imports for deleted attachment command modules

Comment on lines +8 to +9
* Upgrade to API version 2025-12-01-preview
* Remove `add-attachment` and `delete-attachment` commands (no longer supported in new API version)
Copy link

Copilot AI Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HISTORY.rst claims an upgrade to API version 2025-12-01-preview, but none of the code files in this PR have been updated to use this new API version. All remaining command files still reference the old 2025-09-01-preview API version. If the API version is actually being upgraded, the version strings in all the remaining command files need to be updated. If the API version is not being upgraded and only the attachment commands are being removed, this changelog entry should be corrected to remove the claim about upgrading the API version.

Suggested change
* Upgrade to API version 2025-12-01-preview
* Remove `add-attachment` and `delete-attachment` commands (no longer supported in new API version)
* Remove `add-attachment` and `delete-attachment` commands (no longer supported)

Copilot uses AI. Check for mistakes.
@yonzhan yonzhan requested a review from kairu-ms January 8, 2026 00:50
@yonzhan yonzhan requested a review from jsntcy January 8, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants