[Profile] az login: Support --claims-challenge in device code flow
#31856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @jiasli, |
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the --claims-challenge parameter in the device code flow for az login. Previously, claims challenge was only supported in the interactive auth code flow due to MSAL library limitations that have since been resolved.
- Updates the
login_with_device_codemethod to accept and pass through theclaims_challengeparameter - Modifies the profile login logic to pass the claims challenge parameter to device code flow
- Enables consistent claims challenge support across both authentication flows
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/azure-cli-core/azure/cli/core/auth/identity.py | Adds claims_challenge parameter to login_with_device_code method and passes it to MSAL calls |
| src/azure-cli-core/azure/cli/core/_profile.py | Updates device code flow invocation to include claims_challenge parameter |
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
jiasli
force-pushed
the
device_code_claims_challenge
branch
2 times, most recently
from
df32c29 to
3c33eda
Compare
jiasli
requested review from
calvinhzy,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
jiasli
force-pushed
the
device_code_claims_challenge
branch
from
3c33eda to
a306b0f
Compare
evelyn-ys
approved these changes
Aug 12, 2025
bebound
approved these changes
Aug 12, 2025
rayluo
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az login --use-device-codeDescription
#31778 didn't add
--claims-challengefor device code flow because of MSAL limitation AzureAD/microsoft-authentication-library-for-python#834.After MSAL fixes it in AzureAD/microsoft-authentication-library-for-python#839, this PR adds
--claims-challengefor device code flow.Testing Guide
Then verify the access token's
amr(Authentication Methods Reference) claim containsmfa:History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.