{Packaging} Add azure-core dependency to azure-cli-core
#31918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
bebound,
calvinhzy,
evelyn-ys,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a missing dependency issue where azure-cli-core imports azure.core.serialization.attribute_list without explicitly declaring the required azure-core version dependency. The fix adds azure-core~=1.35.0 to the dependencies list to ensure the required functionality is available when installing via pip.
- Adds explicit
azure-core~=1.35.0dependency toazure-cli-core
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
evelyn-ys
approved these changes
Aug 6, 2025
bebound
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #31915
azure.core.serialization.attribute_listwas added by Azure/azure-sdk-for-python#41571 and released inazure-core1.35.0. #31775 created a dependency onazure.core.serialization.attribute_listbut didn't declare the dependency.#31763 bumped
azure-coreto 1.35.0, but only insrc/azure-cli/requirements.py3.*.txt.If
azure-cliis installed viapip,azure-core< 1.35.0 will cause error:This PR adds
azure-core~=1.35.0dependency toazure-cli-core.