{ServiceFabric} Bump azure.mgmt.servicefabricmanagedclusters package version from 2.1.0.1b (2024-06-01-preview) to 2.1.0.3b (2025-03-01-preview) #31949
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Service Fabric
There was a problem hiding this comment.
Pull Request Overview
This PR bumps the azure.mgmt.servicefabricmanagedclusters package version from 2.1.0b1 to 2.1.0b3 and updates the related code to accommodate changes in the SDK structure. The primary change involves wrapping model properties in a properties object, requiring updates to test assertions and operational code.
Key changes include:
- Package version bump in dependency files
- Adaptation of test files to use the new
propertieswrapper structure - Updates to operations code to work with the new SDK model structure
Reviewed Changes
Copilot reviewed 12 out of 25 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py, requirements files | Updates package version from 2.1.0b1 to 2.1.0b3 |
| test_util.py | Updates helper functions to use properties wrapper in assertions |
| test_sf_managed_cluster.py | Converts test assertions to use properties structure |
| test_sf_managed_application.py | Updates application test assertions for new SDK structure |
| test_sf_application.py | Sanitizes sensitive data in test URLs |
| test_application_related.yaml | Sanitizes sensitive data in recorded test responses |
| managed_node_types.py | Updates node type operations to use properties wrapper |
| managed_clusters.py | Updates cluster operations to use properties wrapper |
| managed_applications.py | Updates application operations to use properties wrapper |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_applications.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_applications.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_clusters.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_applications.py
Show resolved
Hide resolved
iliu816
changed the title
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_applications.py
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_applications.py
Outdated
Show resolved
Hide resolved
src/azure-cli/azure/cli/command_modules/servicefabric/operations/managed_node_types.py
Show resolved
Hide resolved
|
since this PR introduces a breaking change, it has to wait for the breaking change window to be released. Alternatively, you could seperate the changes into one PRs: one containing a breaking change and one without. |
I don't think it is possible to actually separate out the change, the breaking change for the parameter requirement is already active on the service side due to pushes from security KPIs. If I don't mark the |
…e version update" This reverts commit 5303a74.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
yanzhudd
modified the milestones:
September 2025 (2025-09-02),
October 2025 (2025-10-14)
@yanzhudd I reverted marking the parameter as required, so there is no breaking change indicated for the cli anymore. However, it seems some checks are still failing on build. Could you please advise on what needs to be done to pass those checks? I don't think I touch the mentioned files. This change being merged is a blocker for other features that we want to add, so would appreciate a resolution. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Please fix CI issues |
Hi @yonzhan, the cause of the build error was not clear to me. I gave merging the latest changes from dev a shot to see if it would resolve the error. Otherwise, I need more guidance on how to resolve the error. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
please resolve the code conflict |
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
@yanzhudd Should be resolved now |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
It seems that this issue may be caused by the introduction of a 
https://pypi.org/project/azure-mgmt-servicefabricmanagedclusters/2.1.0b3/ @msyyc Could you please help take a look if is an issue caused by importing the bool type model into the new version SDK? |
zhoxing-ms
modified the milestones:
October 2025 (2025-10-14),
November 2025 (2025-11-04)
|
2.1.0b3 introduces new hybrid model after |
@jiasli @bebound May I ask could you help to take a look at the breaking changes in the build script patch_models_v2.py caused by the introduction of hybrid models after the SDK was migrated from swagger to typespec ? |
zhoxing-ms
modified the milestones:
November 2025 (2025-11-04),
November 2025 (2025-11-18)❗ Breaking change release ❗
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
November 2025 (2025-11-18)❗ Breaking change release ❗,
December 2025 (2025-12-02)
yanzhudd
modified the milestones:
December 2025 (2025-12-02),
January 2026 (2026-01-06)
6 participants
Related command
az sf managed-application-type version update
Description
Bump the backing azure.mgmt.servicefabricmanagedclusters package version from 2.1.0.1b to 2.1.0.3b and modified backing logic of commands to accommodate.
Testing Guide
N/A, reran scenario tests.
History Notes
{ServiceFabric} Bump azure.mgmt.servicefabricmanagedclusters package version from 2.1.0.1b to 2.1.0.3b
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.