[CosmosDB] az cosmosdb restore: fixes for cross region restore #32589
+1,750
−850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌AzureCLI-FullTest
|
|
Hi @dsapaliga, |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
CosmosDB
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the handling of the source_backup_location parameter for cross-region restore operations in CosmosDB. The parameter was incorrectly being set on DatabaseAccountCreateUpdateParameters instead of on the RestoreParameters object, and the feature is being moved out of preview status.
- Moved
source_backup_locationfromDatabaseAccountCreateUpdateParameterstoRestoreParametersobject - Removed the
is_preview=Trueflag from thesource_backup_locationargument definition
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/cosmosdb/custom.py |
Fixed bug by setting source_backup_location on restore_parameters object (lines 370-371) instead of on DatabaseAccountCreateUpdateParameters (removed from line 405) |
src/azure-cli/azure/cli/command_modules/cosmosdb/_params.py |
Removed is_preview=True flag from source_backup_location argument, indicating the feature is now generally available |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pjohari-ms
approved these changes
Dec 31, 2025
Collaborator
|
Please fix CI issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az cosmosdb restore
Description
This is a simple fix for az cosmosdb restore command where we are enabling a new feature via a new parameter - source-backup-location. This feature is now being GA'd and was released in december in this PR - #32390, but had a bug that needed fixing.
Testing Guide
az cosmosdb restore -n "" -g "" -a "" --restore-timestamp 2023-08-10T07:16:21Z --source-backup-location "Central US EUAP" --location "Central US EUAP"
History Notes
[CosmosDB] az cosmosdb restore: Fix for cross region restore for cosmosdb
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.