Skip to content

Conversation

@w-javed
Copy link
Contributor

@w-javed w-javed commented Jul 11, 2025

PR for #40996

@github-actions github-actions bot added the Evaluation Issues related to the client library for Azure AI Evaluation label Jul 11, 2025
@w-javed w-javed changed the title Fix-for-quoting-issue Fix-for-quoting-issue [Issue # 40996] Aug 12, 2025
@w-javed w-javed changed the title Fix-for-quoting-issue [Issue # 40996] Fix-for-quoting-issue [Issue # 40996][WIP] Aug 12, 2025
@github-actions
Copy link

Hi @w-javed. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions bot added the no-recent-activity There has been no recent activity on this issue. label Oct 17, 2025
@github-actions
Copy link

Hi @w-javed. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions bot closed this Oct 24, 2025
@w-javed w-javed reopened this Jan 9, 2026
@github-actions github-actions bot removed the no-recent-activity There has been no recent activity on this issue. label Jan 9, 2026
@w-javed w-javed marked this pull request as ready for review January 9, 2026 03:48
@w-javed w-javed requested a review from a team as a code owner January 9, 2026 03:48
Copilot AI review requested due to automatic review settings January 9, 2026 03:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a test to verify that the evaluation framework correctly handles quoted strings in JSON input data. The test validates that quotes within JSON string values (e.g., "\"test\"") are preserved correctly when passed to evaluators, addressing issue #40996.

Key Changes:

  • Added a new test evaluator class (QuotationFixEval) that compares input strings
  • Added test data file with quoted string values
  • Added a test case to validate quote preservation behavior

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 9 comments.

File Description
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_evaluators/test_inputs_evaluators.py Adds QuotationFixEval class for testing string comparison with quoted values
sdk/evaluation/azure-ai-evaluation/tests/unittests/test_evaluate.py Adds test fixture and test method to validate quote preservation in evaluation inputs
sdk/evaluation/azure-ai-evaluation/tests/unittests/data/quotation_fix_test_data.jsonl Adds test data with quoted strings to verify quote handling

@w-javed w-javed changed the title Fix-for-quoting-issue [Issue # 40996][WIP] Adding-Tests-Quoting-issue [Issue # 40996][WIP] Jan 9, 2026
@w-javed w-javed enabled auto-merge (squash) January 9, 2026 22:35
@w-javed w-javed merged commit a34e005 into main Jan 9, 2026
20 checks passed
@w-javed w-javed deleted the GitHub_40996_Fix branch January 9, 2026 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Evaluation Issues related to the client library for Azure AI Evaluation work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants