Parameterize diagsettings for appservice

[picccard]

• allow user to select what logs are included
• less repeated code

[DCMattyG]

Would something similar to what you're doing for the App Services deployment also apply to the Function App deployment as well?

[picccard]

Yes, that is true. The reasoning behind this is that the appServicePlan sku P1v3 is quite expensive (when testing / proof-of-consept), and it can not scale down to sku B1 without first removing any "premuim sku dignostic settings".

So both diagSettings and sku names is something I would like to choose myself as I'm deploying.

[DCMattyG]

While that is true, I've done extensive testing and the Engine container is extremely resource intensive due to the numerous calculations it performs. Reducing the SKU is highly discouraged because it has a quite negative impact on the performance of the solution.

I'm not opposed to this, but perhaps we'll need some documentation explaining that while you CAN lower the SKU, we can only guarantee performance when using SKU's X/Y/Z, for example. I'm trying to avoid numerous GitHub issues related to performance when end users have knowingly chosen a SKU that will impact the performance of the IPAM solution.

I hope that makes sense...