-
Notifications
You must be signed in to change notification settings - Fork 103
Formatted and trimmed trailing whitespace in deployscript #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for this @picccard, I agree this makes it more readable. I'll also add some formatting rules into the project that better enforce this where possible. Appreciate the cleanup! |
|
Appreciate the formatting @picccard, my apologies for the mistake in my now deleted comment.... What I mean to say was that for PowerShell files, I currently have it set to using 2x Spaces as a TAB as when using 4x Spaces it looks a bit too clunky. I have the same settings applied for JavaScript as well which follows a similar format. For Python, we use 4x Spaces as a TAB since Python is indentation-sensitive, whereas PowerShell and JavaScript are not. Does that make sense and/or do you agree? TL:DR - For languages that aren't sensitive to indentation, 2x Spaces / TAB looks a bit nicer and has less empty whitespace. |
|
Thank you so much @picccard, appreciate you! |
|
Python code for the engine is using 4 spaces and javascript code for the ui is using 2 spaces. Perhaps the project should have some contributing guidelines? Example from ALZ-Bicep Contributing EDIT: forgot to reload my page, seems we are in agreement 😄 |
|
That's a great point @picccard, I'll definitely work on that. Haven't had many contributions in the last few years and all of the sudden I have more than I can handle hahaha! Good problem to have. |
|
Hey @picccard, there were a lot of updates in the recent release and this PR will need those changes merged in before we can proceed. Thanks so much! |
Makes the deployscript more readable by formating and trimming trailing whitespace with vscode