-
Notifications
You must be signed in to change notification settings - Fork 131
Disable _TqdmCloser darwin workaround for Python >= 3.14.2 #1128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
After enabling integration tests for macos - Python 3.13 pair, the tqdm closer test is now failing there too, which implies that it has something to do with the MacOS version as opposed to Python version. Here is a recent job (from last month) where the test was passing on MacOS and Python 3.13: It used the following image: The last workflow (where the test fails) uses: |
|
MacOS 15.7.2 release notes do mention some fixes of memory-related issues on the Kernel level, that potentially could have resolved the tqdm leaked semaphore objects problem |
44fc2cb to
cac1f01
Compare
_TqdmCloser is a workaround for leaked semaphores error happening when using tqdm on MacOS and Python >= 3.11. The issue does not seem to appear in MacOS 15.7.2, so we disable the workaround for newer MacOS versions
cac1f01 to
3f474ec
Compare
| f'b2://{bucket.name}/{file_name}', | ||
| ] | ||
| ) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second part of the test does not make much sense now that the newer MacOS image is used in the CI
mlech-reef
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codewise, it looks ok. If the CI proves everything works on 15. 7. 2, it lgtm
|
Yeap, the remaining test that checks for a clean output without warnings passes on MacOS 5.17.2. https://github.com/Backblaze/B2_Command_Line_Tool/actions/runs/20351177710/job/58743915427?pr=1128 On the other hand, on my machine with MacOs 5.16.1, there are still warnings with |
_TqdmCloser is a workaround for leaked semaphores error happening when
using tqdm on MacOS and Python >= 3.11. The issue does not seem to
appear in Python 3.14.2, so we disable the workaround for newer Python
versions