-
Notifications
You must be signed in to change notification settings - Fork 18
Lucarelli visualization #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Can I somewhere preview the visualization? Could you add please an image? |
|
Axis label is |
|
Unclear for me as well, first figure is okay. |
|
LGTM, thanks Polina! |
m-philipps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plots look good! Is there a way to do the visualisation without adding a column without header to the measurement table?
This column is not needed and can be removed. Do you think it could be helpful to move this information to the simulations table, or remove completely? |
stephanmg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
I think it's nice to keep. I think the column in the visualization table is probably enough, since it can be used to both identify the figure that is reproduced, and the data that goes into the figure. Call it e.g. |
dilpath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
m-philipps
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
















I am not sure that I correctly identified data from the figures in the original publication.
So the notes in the measurements table and the visualization table (the rightmost column) are just my guesses.