Simplify Froehlich_CellSystems2018 condition table #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilpath
approved these changes
Nov 26, 2025
Collaborator
dilpath
left a comment
dilpath
left a comment
There was a problem hiding this comment.
Thanks! Could you confirm that this new problem produces the same NLLH as the old model with the same parameters? If so, then I'm fine to merge this.
Out of curiosity, if you already know, why are the model parameters changed from something specific to just 1?
The current condition table for Froehlich_CellSystems2018 is unnecessarily large (37.2MB). There are 477 parameters that take the same across all conditions, which is also the same value as already specified in the SBML model. Thus, drop the respective columns from the condition table.
…e across all conditions, but a different value is set in the model. Update the value in the model and drop the respective columns from the condition table.
dweindl
force-pushed
the
Froehlich_CellSystems2018_simplify
branch
from
bc4a042 to
ce1731a
Compare
Member
Author
Old:
I seem to recall that there was a discussion on that about 8 years ago, but I don't recall the reasons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current condition table for Froehlich_CellSystems2018 is unnecessarily large (37.2MB):