Skip to content

Conversation

@dweindl
Copy link
Member

@dweindl dweindl commented Nov 25, 2025

Add workflow to check that all problems can be simulated. This will run for quite some time.

@dweindl dweindl self-assigned this Nov 25, 2025
@dweindl dweindl force-pushed the simulate branch 5 times, most recently from 6d8b1ca to cb4604d Compare November 25, 2025 12:05
@dweindl dweindl marked this pull request as ready for review November 25, 2025 12:26
Copy link
Collaborator

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 Is it possible to limit this only to PRs once they are added to a merge queue (merge_group), so that the test isn't run on every commit? Or would you like it to be run on every commit?

@dweindl
Copy link
Member Author

dweindl commented Nov 26, 2025

Thanks 👍 Is it possible to limit this only to PRs once they are added to a merge queue (merge_group), so that the test isn't run on every commit? Or would you like it to be run on every commit?

Possible, definitely. First the merge queue needs to be set up, though. Also fine to just run it on a daily/weekly basis.
Traffic here is pretty low, so currently I don't think there is a big problem with running it on each push. We don't have to require that check to pass before merging.
In the longer term, this could be extended to run only on the changed problems in each pull request.

I'll just set it to daily for now.

Add workflow to check that all problems can be simulated.
This will run for quite some time.
@dweindl
Copy link
Member Author

dweindl commented Nov 26, 2025

I'll just set it to daily for now.

daily, and pushes to master

@dweindl dweindl merged commit 5b868c3 into master Nov 26, 2025
6 checks passed
@dweindl dweindl deleted the simulate branch November 26, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants