fix incorect varible types after block flattening #1635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blk.flatten produces new variables with incorrect type after flattening expressions with extract or concat expressions.
On extract expressions the new variable gets the type of the expression inside the extract and not the size (high - low + 1).
On concat expressions the new variable gets the type of the second expression and not the added size of the two expressions,
after the changes the type is the sum of sizes of the types of the expressions if the expressions are of type Imm otherwise if any of the expressions are of Unknown type the new variable type is also unknown. Lastly, i don't know how to define concat on memories so i call failwith.