Fix coverage infrastructure

[ipv1337]

No description provided.

[gemini-code-assist]

Hello @ipv1337, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request focuses on improving the code coverage infrastructure for the project. It introduces a new convenience script, run_tests_with_coverage.py, to simplify running tests with coverage analysis and generating HTML and XML reports. The README has been updated to reflect this change, and the .pytest.ini file now includes markers for integration and slow tests. Additionally, the pyproject.toml file has been modified to exclude certain directories from coverage analysis.

Highlights

• Coverage Script: A new script, run_tests_with_coverage.py, has been added to streamline the process of running tests with coverage and generating reports.
• README Update: The README file has been updated to reflect the new coverage script and provide instructions on its usage.
• Pytest Configuration: The .pytest.ini file now includes markers for integration and slow tests.
• Coverage Exclusions: The pyproject.toml file has been modified to exclude venv, .pytest_cache, and site-packages directories from coverage analysis.
• Expanded Testing: New tests were added to increase coverage of the Config class and the Ollama/Gemini model classes.

Changelog

Click here to see the changelog

• .pytest.ini
  • Added markers for integration and slow tests.
  • Added src to python paths
• README.md
  • Replaced the old coverage analysis command with the new run_tests_with_coverage.py script.
  • Added a section on code coverage, including instructions and goals.
• pyproject.toml
  • Excluded venv, .pytest_cache, and site-packages directories from coverage analysis.
• run_tests_with_coverage.py
  • Created a new script to run tests with coverage reporting and generate HTML and XML reports.
  • Includes options to open the HTML report, generate an XML report, skip running tests, and increase verbosity.
• test_dir/test_config_missing_methods.py
  • Added tests for Config class methods that were previously uncovered, such as get_credential, set_credential, get_default_provider, set_default_provider, get_default_model, set_default_model, get_setting, set_setting, and _save_config.
• test_dir/test_gemini_model.py
  • Added tests specifically for the GeminiModel class to improve code coverage, focusing on previously uncovered methods such as _get_initial_context, _create_tool_definitions, _create_system_prompt, _manage_context_window, _extract_text_from_response, _find_last_model_text, add_to_history, clear_history, _get_help_text, and generate with function calls.
• test_dir/test_ollama_model.py
  • Added tests specifically for the OllamaModel class to improve code coverage, focusing on previously uncovered methods such as _get_initial_context, _prepare_openai_tools, _manage_ollama_context, add_to_history, clear_history, list_models, and generate with function calls.
• test_dir/test_system_tools_comprehensive.py
  • Added comprehensive tests for the system_tools module, including tests for BashTool initialization, banned commands, simple command execution, error handling, timeout handling, exception handling, timeout conversion, long output handling, and commands with arguments.
• test_dir/test_utils_comprehensive.py
  • Added comprehensive tests for the utils module, including tests for count_tokens with various inputs and a mocked failure scenario.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Coverage gaps, a coder's plight,
Tests emerge, shining bright,
Bugs take flight.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a new coverage infrastructure, including a new script for running tests with coverage, updates to the README, and new test files. The changes aim to improve code quality and reliability by ensuring comprehensive test coverage.

Summary of Findings

• README.md: Clarity and Conciseness: The README.md update introduces a new section on code coverage. While informative, some parts could be more concise and directly address the user. Consider streamlining the language to improve readability.
• pyproject.toml: Coverage Omission: The pyproject.toml file adds several paths to the coverage omit list. Ensure these paths are intentionally excluded and that this exclusion doesn't negatively impact the overall coverage analysis.
• run_tests_with_coverage.py: Error Handling: The run_tests_with_coverage.py script includes error handling for processing coverage reports. Ensure that the error messages are informative enough to help users diagnose and resolve issues.
• Test Files: Comprehensive Testing: The addition of new test files (test_config_missing_methods.py, test_gemini_model.py, test_ollama_model.py, test_system_tools_comprehensive.py, test_utils_comprehensive.py) significantly improves test coverage. Ensure that these tests cover edge cases and error handling scenarios adequately.

Merge Readiness

The pull request introduces significant improvements to the project's coverage infrastructure. However, before merging, it's crucial to address the medium and high severity issues identified in the review comments. I am unable to approve this pull request, and recommend that others review and approve this code before merging. Once these issues are resolved, the pull request will be in good shape to be merged.