Issue #293 - Min barb distance #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
away from barb camps. Added GameMap parameter to TileIsTooCloseToOtherStarts(), created minimum barb camp distance logic with magic numbers, added enumerable all function to make sure that player spawns are required minimum distance from barb camps.
Game places too many barb camps to place player spawns a small distance away if we do barbs first.
Contributor
|
Looks good to me! I'll take a look at the other PR you mention too. |
Contributor
Author
|
Staging this one as ready to merge if desired since the world sizes issue may have a bit more nuance to iron out. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swapped the map generation order from place barbs -> place players to place players -> place barbs. Added control flow gate to invalidate any barbarian spawn candidate that's less than 6 tiles away from an already placed player location.
Waiting to finalize PR until older PR's are good to go (i.e. the world size option update)