Skip to content

Conversation

@chivalryq
Copy link

@chivalryq chivalryq commented Oct 13, 2025

User description

See

Fixes #80


PR Type

Bug fix, Dependencies


Description

  • Replace turtlemonvh/gin-wraphh dependency with scr-oath/gin-wraphh fork

  • Update to version with fix for 404 panic issue

  • Modify import statements and go.mod/go.sum files accordingly


Diagram Walkthrough

flowchart LR
  A["turtlemonvh/gin-wraphh"] -- "replace with" --> B["scr-oath/gin-wraphh"]
  B -- "fixes" --> C["404 panic issue"]
Loading

File Walkthrough

Relevant files
Dependencies
gin.go
Replace gin-wraphh import with forked version                       

contrib/gin-gonic/gin/gin.go

  • Updated import statement from turtlemonvh/gin-wraphh to
    scr-oath/gin-wraphh
+1/-1     
go.mod
Update go.mod with patched dependency version                       

contrib/gin-gonic/gin/go.mod

  • Replaced turtlemonvh/gin-wraphh dependency with scr-oath/gin-wraphh
  • Updated to version v0.0.0-20250205052857-624904308e7f from
    7-fix-writer branch
+1/-1     
go.sum
Update dependency checksums for new fork                                 

contrib/gin-gonic/gin/go.sum

  • Removed old turtlemonvh/gin-wraphh checksums
  • Added new scr-oath/gin-wraphh checksums for updated version
+2/-2     

@qodo-free-for-open-source-projects
Copy link

qodo-free-for-open-source-projects bot commented Oct 13, 2025

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Supply chain risk

Description: The PR switches to a personal fork dependency github.com/scr-oath/gin-wraphh pinned to a
pseudo-version without clear provenance, which may increase supply chain risk and should
be vetted and pinned to a trusted, immutable tag or commit with code review.
go.mod [6-9]

Referred Code
	github.com/CAFxX/httpcompression v0.0.8
	github.com/gin-gonic/gin v1.9.1
	github.com/scr-oath/gin-wraphh v0.0.0-20250205052857-624904308e7f // 7-fix-writer branch
)
Ticket Compliance
🟡
🎫 #80
🟢 Address upstream gin-wraphh issue (per linked issue) either by integrating the fix or
replacing the dependency with a fixed fork.
Update project to use the fixed WrapHH implementation so gin HandlerChain handles 404
correctly.
Ensure 404 Not Found paths do not cause empty reply/panic when compression middleware is
enabled.
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

  • Update
Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-free-for-open-source-projects
Copy link

qodo-free-for-open-source-projects bot commented Oct 13, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use tagged release instead of branch

Replace the dependency on the gin-wraphh feature branch with a tagged release to
mitigate maintenance and stability risks.

contrib/gin-gonic/gin/go.mod [8]

-github.com/scr-oath/gin-wraphh v0.0.0-20250205052857-624904308e7f // 7-fix-writer branch
+github.com/scr-oath/gin-wraphh v1.0.0 // Use a proper tagged release
  • Apply / Chat
Suggestion importance[1-10]: 8

__

Why: The suggestion correctly identifies a dependency on a feature branch via a pseudo-version, which poses a significant risk to build stability and project maintainability.

Medium
  • Update

@CAFxX
Copy link
Owner

CAFxX commented Oct 27, 2025

Should we switch to https://github.com/gwatts/gin-adapter instead?

@chivalryq
Copy link
Author

Well, it looks to be a better maintained lib. And I like the repository name, more explicit. But it need to be tested in battlefield, we can give it a try?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug with underlying gin-wraphh module causes 404 to not work properly

2 participants