-
Notifications
You must be signed in to change notification settings - Fork 60
Feat:add project picker for task dialog #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat:add project picker for task dialog #332
Conversation
|
Thank you for opening this PR! Before a maintainer takes a look, it would be really helpful if you could walk through your changes using GitHub's review tools. Please take a moment to:
More information on how to conduct a self review: This helps make the review process smoother and gives us a clearer understanding of your thought process. Once you've added your self-review, we'll continue from our side. Thank you! |
| > | ||
| <XIcon className="h-4 w-4 text-red-500" /> | ||
| </Button> | ||
| <SelectTrigger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added ✓ ✖ for new project creation option but when you select from exixting project we dont need to save it ising onsaveproject fnc it saves without it
Neeraj-gagat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update interfaces and props in other files thats all done with the selfreview it breaks nothing all test passes and it works as expected
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work! Thanks for the PR!
Description
This Pr adds project selector and new project creator in taskdialog as it was requested in #324
Now we can select from existing project and create new project whhile editing task same as could do in addtask while adding new task
- Fixes: #324
video
Screencast.from.27-12-25.05.54.28.AM.IST.webm