Rework sacrifice cost text #8830
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanmac
reviewed
Oct 9, 2025
Comment on lines
101
to
102
| public static String complexTargetTypesToString(String types, boolean pluralize) { | ||
| String[] parts = types.split(";"); |
Contributor
There was a problem hiding this comment.
i would do the split outside, because then we could use it for Valid that uses , as Split
Contributor
Author
There was a problem hiding this comment.
I've made it so you can pass the split regex as parameter.
Contributor
There was a problem hiding this comment.
The parameter types is only used to be split into String[] parts
wouldn't it be better to pass String[] parts directly as parameter?
Contributor
Author
There was a problem hiding this comment.
Good point. I'll change it next time.
Contributor
|
This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #5916