Skip to content

Protection: replace with Pump when defined #9414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Hanmac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Protection: replace with Pump when defined #9414

Hanmac wants to merge 1 commit into from
+12 −13

Conversation

@Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Jan 4, 2026

Part of #8692

this replaces Protection Effects with fixed values with Pump Effects

@Hanmac Hanmac requested a review from tool4ever January 4, 2026 19:35
@tool4ever
Copy link
Contributor

tool4ever commented Jan 4, 2026

I don't see the benefit when a special effect for it exists :/
This will also just make the AI dumber because it's no longer using logic of ProtectAi

@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 5, 2026

@tool4ever see the linked issue with the list of problems

I wanted to change that up later to support MagicColor enum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tool4ever tool4ever Awaiting requested review from tool4ever

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Game Mechanics

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hanmac @tool4ever