Skip to content

Conversation

@LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Jan 8, 2026

Summary of changes

Changes introduced in this pull request:

  • added more items to dockerignore (no difference for the end image, but should lower the size of build images on the system)

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Summary by CodeRabbit

  • Chores
    • Optimized Docker image builds by excluding unnecessary files and directories from the build context.

✏️ Tip: You can customize this high-level summary in your review settings.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner January 8, 2026 14:57
@LesnyRumcajs LesnyRumcajs requested review from akaladarshi and hanabi1224 and removed request for a team January 8, 2026 14:57
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 8, 2026

Walkthrough

Updated .dockerignore configuration file by removing one entry and adding ten new patterns to exclude additional directories and files (benches, .yarn, docs, monitored-stack, node_modules, test-snapshots, tests, tools, LICENSE variants, and CHANGELOG variants) from Docker image builds.

Changes

Cohort / File(s) Change Summary
Docker build configuration
.dockerignore
Removed .maintain entry; added 10 new exclusion patterns for build artifacts, documentation, dependencies, and changelog/license files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: add more items to dockerignore' directly and clearly describes the main change—adding entries to the .dockerignore file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0af174d and 8fd06e0.

📒 Files selected for processing (1)
  • .dockerignore
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: LesnyRumcajs
Repo: ChainSafe/forest PR: 5907
File: src/rpc/methods/state.rs:523-570
Timestamp: 2025-08-06T15:44:33.467Z
Learning: LesnyRumcajs prefers to rely on BufWriter's Drop implementation for automatic flushing rather than explicit flush() calls in Forest codebase.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: tests-release
  • GitHub Check: Build MacOS
  • GitHub Check: Build Ubuntu
  • GitHub Check: Build forest binaries on Linux AMD64
  • GitHub Check: cargo-publish-dry-run
  • GitHub Check: Coverage
  • GitHub Check: All lint checks
🔇 Additional comments (1)
.dockerignore (1)

2-16: No action required — Docker builds are compatible with the excluded directories.

All Dockerfiles in the repository (scripts/devnet/forest_ci.dockerfile, scripts/devnet/lotus.dockerfile, scripts/devnet-curio/curio.dockerfile) do not reference any of the newly excluded paths. The changes to .dockerignore are safe and will reduce the build context without impacting image construction.


Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.49%. Comparing base (0af174d) to head (8fd06e0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 11 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0af174d...8fd06e0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LesnyRumcajs LesnyRumcajs enabled auto-merge January 8, 2026 15:27
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Jan 8, 2026
Merged via the queue into main with commit 7386847 Jan 8, 2026
43 checks passed
@LesnyRumcajs LesnyRumcajs deleted the move-more-to-dockerignore branch January 8, 2026 22:03
@coderabbitai coderabbitai bot mentioned this pull request Jan 9, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants