Math.Truncate rounds towards 0. Use FIX instead of INT to match that behaviour #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the Math.Truncate translation for the EF Core Jet provider by changing the SQL function from INT to FIX. The issue was that INT always rounds down (floor behavior), while Math.Truncate should round towards zero, which FIX correctly implements for both positive and negative numbers.
- Changed SQL function translation from
INTtoFIXinJetMathTranslator - Updated all test assertions to reflect the corrected SQL generation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/EFCore.Jet/Query/ExpressionTranslators/Internal/JetMathTranslator.cs |
Updated the Math.Truncate translation to use FIX instead of INT function |
test/EFCore.Jet.FunctionalTests/Query/NorthwindFunctionsQueryJetTest.Functions.cs |
Updated test assertions to expect FIX function calls in generated SQL queries |
ChrisJollyAU
added a commit
to ChrisJollyAU/EntityFrameworkCore.Jet
that referenced
this pull request
Oct 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of updating to .Net 10, found a bug with the
Math.Truncatetranslation.Math.Truncaterounds towards 0.We were originally using the function
INThowever that always rounds down. So negative values were rounded away from 0.The other function
FIXhas the correct behaviour