Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
336 commits
Select commit Hold shift + click to select a range
4d121d3
Refactor: based: cib_process_shutdown_req() -> based_process_shutdown()
nrwahl2 Dec 22, 2025
a44f706
Refactor: libcib: cib__op_sync_{all,one} -> cib__op_sync_to_{all,one}
nrwahl2 Dec 22, 2025
f93a611
Refactor: based: cib_process_sync() -> based_process_sync_to_all()
nrwahl2 Dec 22, 2025
a5bbc00
Refactor: based: cib_process_sync_one() -> based_process_sync_to_one()
nrwahl2 Dec 22, 2025
18c0eb5
Refactor: based: cib_process_upgrade_server() -> based_process_upgrade()
nrwahl2 Dec 22, 2025
300bb30
Refactor: based: cib_process_schemas() -> based_process_schemas()
nrwahl2 Dec 22, 2025
7942cc1
Refactor: libcib: cib_process_replace() -> cib__process_replace()
nrwahl2 Dec 22, 2025
68d17d9
Refactor: libcib: cib_process_upgrade() -> cib__process_upgrade()
nrwahl2 Dec 22, 2025
350269d
Refactor: based: New based_remote.h
nrwahl2 Dec 22, 2025
71b845d
Refactor: based: Remove remote FD variables to based_remote.c
nrwahl2 Dec 22, 2025
65fdc26
Refactor: based: New based_remote_init()
nrwahl2 Dec 22, 2025
ee8b5b0
Refactor: based: Drop cib variable from startCib()
nrwahl2 Dec 22, 2025
41c7593
Refactor: based: Drop startCib()
nrwahl2 Dec 22, 2025
3678cc9
Refactor: based: Drop num_clients variable
nrwahl2 Dec 22, 2025
7df3626
Refactor: based: Check pcmk__scan_port() return code for remote ports
nrwahl2 Dec 22, 2025
9ad8e02
Refactor: libcrmcommon: Simplify pcmk__init_tls() cred type selection
nrwahl2 Dec 22, 2025
7f931b6
Refactor: based: Drop init_remote_listener() encrypted argument
nrwahl2 Dec 22, 2025
444c629
Refactor: based: Drop forward declaration for authenticate_user()
nrwahl2 Dec 22, 2025
c0eea95
Refactor: based: Drop forward declaration for cib_remote_listen()
nrwahl2 Dec 22, 2025
04a5323
Refactor: based: Drop forward declaration for cib_remote_msg()
nrwahl2 Dec 22, 2025
a7e4ad5
Refactor: based: Drop cib_remote_connection_destroy forward declaration
nrwahl2 Dec 22, 2025
9c66d42
Refactor: based: Use G_SOURCE_REMOVE in remote_auth_timeout_cb()
nrwahl2 Dec 22, 2025
7ace00e
Doc: libcrmcommon: Add a clarifying note to pcmk__create_timer()
nrwahl2 Dec 23, 2025
0cf48a2
Refactor: libcrmcommon: Move pcmk__remote_t def to remote_internal.h
nrwahl2 Dec 23, 2025
e16d7cb
Refactor: libcrmcommon: Drop struct pcmk__client_s
nrwahl2 Dec 23, 2025
e05cae8
Refactor: libcrmcommon: Unindent mainloop_del_fd()
nrwahl2 Dec 23, 2025
6275778
Refactor: based: Drop redundant checks in is_daemon_group_member()
nrwahl2 Dec 23, 2025
dc4c466
Refactor: based: Unindent contains_config_change()
nrwahl2 Dec 23, 2025
73aea82
Refactor: based: Drop forward declaration for cib_process_command()
nrwahl2 Dec 23, 2025
59efdbb
Refactor: based: Drop forward declaration for cib_common_callback()
nrwahl2 Dec 23, 2025
3123a80
Refactor: based: Rename cib_process_request() cib_client arg to client
nrwahl2 Dec 23, 2025
8e4cbab
Refactor: based: Rename cib_process_request() to based_process_request()
nrwahl2 Dec 23, 2025
6e9d40d
Refactor: based: Rename cib_peer_callback() to based_peer_callback()
nrwahl2 Dec 23, 2025
03fee9d
Refactor: based: Rename cib_common_callback_worker()
nrwahl2 Dec 23, 2025
f122911
Refactor: based: Rename cib_shutdown() to based_shutdown()
nrwahl2 Dec 23, 2025
415e3ae
Refactor: based: Rename terminate_cib() to based_terminate()
nrwahl2 Dec 23, 2025
f2aa1fb
Refactor: based: New based_callbacks.h
nrwahl2 Dec 23, 2025
0482a11
Refactor: based: Drop cib_config_lookup()
nrwahl2 Dec 23, 2025
21863e7
Refactor: based: Functionize logging result of cib_process_command()
nrwahl2 Dec 23, 2025
18b19d5
Refactor: based: Very minor cleanups in based_process_request()
nrwahl2 Dec 23, 2025
c42e93f
Refactor: based: Reduce duplication in do_local_notify()
nrwahl2 Dec 23, 2025
20fd6a9
Refactor: based: Split IPC callbacks into their own file
nrwahl2 Dec 23, 2025
f8dcd7c
Refactor: based: Rename functions in based_ipc.c
nrwahl2 Dec 23, 2025
d6ccf97
Refactor: based: Standardize functions in based_ipc.c
nrwahl2 Dec 23, 2025
2157a79
Feature: libcib: {add,del}_notify_callback support only cib_diff_notify
nrwahl2 Dec 24, 2025
b6d0437
Refactor: based: Rename cib_client_flags
nrwahl2 Dec 24, 2025
693716d
Refactor: based: New based_parse_notify_flag()
nrwahl2 Dec 24, 2025
7f1c8e4
Refactor: libcrmcommon: Correct the Doxygen for pcmk__xe_attr_is_true()
nrwahl2 Dec 24, 2025
d8c6564
Refactor: based: Functionize updating client notify flags
nrwahl2 Dec 24, 2025
a78947b
Refactor: based: Add client type guards in based_common_callback_worker
nrwahl2 Dec 24, 2025
d929a3e
Refactor: based: Rename cib_client to client in based_callbacks.c
nrwahl2 Dec 24, 2025
73a6499
Refactor: based: Clarify that CRM_OP_REGISTER response is only for IPC
nrwahl2 Dec 24, 2025
154d5a7
Refactor: based: Improve a log message for IPC call options
nrwahl2 Dec 24, 2025
0aefd4b
Refactor: based: Move cib_transaction checks out of based_callbacks.c
nrwahl2 Dec 24, 2025
88e9494
Refactor: based: Drop based_common_callback_worker()
nrwahl2 Dec 24, 2025
a7d490f
Refactor: based: Unindent cib_digester_cb() and return G_SOURCE_REMOVE
nrwahl2 Dec 24, 2025
3a0901f
Refactor: based: cib_digester_cb() Doxygen and small improvements
nrwahl2 Dec 24, 2025
c2c2c22
Refactor: libcib: Return standard code from cib_perform_op()
nrwahl2 Dec 24, 2025
1a8fda9
Refactor: based, libcib: Drop cib_force_diff-related dead code
nrwahl2 Dec 24, 2025
befd17d
API: libcib: Deprecate cib_force_diff
nrwahl2 Dec 24, 2025
61ce836
Log: based: Drop unhelpful trace messages
nrwahl2 Dec 24, 2025
ade3287
Feature: tools: Drop crm_attribute --attr-id option
nrwahl2 Dec 24, 2025
9151d9d
Feature: tools: Drop crm_attribute --attr-value/--delete-attr options
nrwahl2 Dec 24, 2025
6fc3eb9
Feature: tools: Drop crm_attribute --inhibit-policy-engine/-i option
nrwahl2 Dec 24, 2025
f560a1d
API: libcib: Deprecate cib_inhibit_notify
nrwahl2 Dec 24, 2025
29e00f0
Doc: libcrmcommon: Correct Doxygen for pcmk_find_cib_element()
nrwahl2 Dec 24, 2025
3f23580
Refactor: based: Drop config_hash
nrwahl2 Dec 24, 2025
213efab
Refactor: libcib: cib_read_config() is now static
nrwahl2 Dec 24, 2025
659a8f5
Refactor: libcib: Unindent cib_acl_enabled()
nrwahl2 Dec 24, 2025
f4c054d
Refactor: libcib: Simplify read_config()
nrwahl2 Dec 24, 2025
81deeaf
Refactor: libcib: Split out is_query block of cib_perform_op()
nrwahl2 Dec 24, 2025
b6652c1
Refactor: libcib: Improve cib__perform_query/cib_perform_op assertions
nrwahl2 Dec 24, 2025
5816a23
Refactor: libcib: Drop cib__perform_query() result_cib argument
nrwahl2 Dec 24, 2025
17981b0
Refactor: libcib: Move cib__op_schemas to alphabetical position in table
nrwahl2 Dec 25, 2025
64e5caa
Doc: libcib: Clarify comment in cib_perform_op()
nrwahl2 Dec 24, 2025
66c1b02
Fix: libcib: Fix setting origin attributes in CIB updates
nrwahl2 Dec 24, 2025
a609890
Refactor: libcib: Drop check_schema variable
nrwahl2 Dec 29, 2025
d2f0868
Refactor: libcib: Assume req != NULL in cib__process_apply_patch()
nrwahl2 Dec 29, 2025
ea68c6f
Refactor: libcib: Functionize replacing entire CIB
nrwahl2 Dec 29, 2025
0238f75
Refactor: libcib: Functionize checking CIB replacement digest
nrwahl2 Dec 29, 2025
c91c5d6
Refactor: libcib: Use pcmk__is_set() in cib_ops.c
nrwahl2 Dec 30, 2025
d4d7e7f
Refactor: libcib: Drop unused process_xpath() req argument
nrwahl2 Dec 30, 2025
c835cfa
Refactor: libcib: New process_query_xpath()
nrwahl2 Dec 30, 2025
139701b
Refactor: libcib: New process_delete_xpath()
nrwahl2 Dec 30, 2025
9ab6024
Refactor: libcib: New process_modify_xpath()
nrwahl2 Dec 30, 2025
6cc947b
Refactor: libcib: New process_create_xpath()
nrwahl2 Dec 30, 2025
ffd6334
Refactor: libcib: New process_replace_xpath()
nrwahl2 Dec 30, 2025
e4019cc
Refactor: libcib: Return standard RC from cib__op_fn_t
nrwahl2 Dec 30, 2025
d293ba4
Refactor: libcib: New process_delete_section()
nrwahl2 Dec 30, 2025
d2634b5
Refactor: libcib: New process_modify_section()
nrwahl2 Dec 30, 2025
d4cca13
Refactor: libcib: New process_query_section()
nrwahl2 Dec 30, 2025
3ec0e91
Refactor: libcib: Drop shallow variable from process_query_section()
nrwahl2 Dec 30, 2025
04cac4c
Refactor: libcib: Drop dead code from process_query_section()
nrwahl2 Dec 30, 2025
95d095d
Refactor: libcib: New process_replace_section()
nrwahl2 Dec 31, 2025
187955d
Log: libcib, based: Consolidate "Processing" trace logs
nrwahl2 Dec 31, 2025
9864997
Refactor: libcib: Simplify update_counter()
nrwahl2 Dec 31, 2025
cbc4702
Refactor: libcib: Drop redundant setting of *answer to NULL
nrwahl2 Dec 31, 2025
51b38a1
Refactor: libcib: Unindent cib_apply_patch_event()
nrwahl2 Dec 31, 2025
4f3919d
Refactor: libcib: Unindent more of cib_apply_patch_event()
nrwahl2 Dec 31, 2025
c4302a6
Refactor: libcib: Allow cib__process_apply_patch() to use existing_cib
nrwahl2 Dec 31, 2025
adf9d46
Refactor: based: Drop unused based_diff_notify() argument
nrwahl2 Dec 31, 2025
f918f3c
Refactor: libcib: Get attributes from result CIB instead of existing CIB
nrwahl2 Dec 31, 2025
7b11ac1
Refactor: libcib: Log correct error message in replace_cib()
nrwahl2 Dec 31, 2025
72e1635
Refactor: libcib: Free *result_cib only on success in replace_cib()
nrwahl2 Dec 31, 2025
22c2cf1
Refactor: libcib: Free *result_cib unconditionally in cib__process_er…
nrwahl2 Dec 31, 2025
3f3cdd7
Refactor: based: Get versions from *result_cib in based_process_ping()
nrwahl2 Dec 31, 2025
b4e7d8c
Refactor: based: Copy based on *result_cib in based_process_upgrade()
nrwahl2 Dec 31, 2025
c01b8f1
Refactor: libcib: cib_process_erase() doesn't free its cib argument
nrwahl2 Jan 2, 2026
7daf341
Test: cts-cli: Use word boundaries for CIB version attributes
nrwahl2 Jan 2, 2026
cafc57c
Feature: libcib, tools: Empty CIB contains admin_epoch before epoch
nrwahl2 Jan 2, 2026
c76be62
Refactor: libcrmcommon: New pcmk__xml_replace_with_copy()
nrwahl2 Jan 2, 2026
3690a8b
Refactor: libcib: Replace CIB with a copy of input in same doc
nrwahl2 Jan 2, 2026
814ad53
Refactor: libcib: Merge existing_cib and result_cib args of cib__op_fn_t
nrwahl2 Dec 31, 2025
8d1126a
Refactor: libcib: Return standard code from cib_file.c:process_request()
nrwahl2 Dec 31, 2025
606b3ca
Refactor: libcib: Return standard code from cib__extend_transaction()
nrwahl2 Dec 31, 2025
a4d6ebe
Refactor: libcib: Return standard code from cib__create_op()
nrwahl2 Dec 31, 2025
89b6983
Refactor: libcib: Assert *current_cib != scratch when make_copy true
nrwahl2 Dec 31, 2025
9c8d4c0
Refactor: libcib: Rename scratch to working_cib in cib_perform_op()
nrwahl2 Dec 31, 2025
df20540
Refactor: libcib: New set_update_origin() for cib_perform_op()
nrwahl2 Dec 31, 2025
4e23ff3
Log: libcib: Drop unhelpful trace message
nrwahl2 Dec 31, 2025
5e8d1fd
Low: libcrmcommon: Handle NULL and PCMK_XA_FORMAT and PCMK_XA_DIGEST
nrwahl2 Dec 31, 2025
5e48b79
Test: cts-cli: Update outputs for "(no digest)"
nrwahl2 Dec 31, 2025
7b10aad
Refactor: libcib: Add digest in cib_perform_op if and only if tracing
nrwahl2 Dec 31, 2025
f7a4f12
Refactor: libcib: Drop test apply-patchset when tracing cib_perform_op()
nrwahl2 Dec 31, 2025
6d13837
Refactor: libcib: Drop make_copy variable
nrwahl2 Dec 31, 2025
1ebc65b
Refactor: libcib: Functionize checking versions in cib_perform_op()
nrwahl2 Dec 31, 2025
862e532
Refactor: libcib: Simplify some return-code handling in cib_perform_op()
nrwahl2 Dec 31, 2025
d241989
Refactor: libcib: Drop redundant NULL check in cib_perform_op()
nrwahl2 Dec 31, 2025
950e611
Refactor: libcib: cib_perform_op() takes enum cib_variant arg
nrwahl2 Dec 31, 2025
8accd05
Refactor: libcib: Functionize checking new feature set in cib_perform_op
nrwahl2 Dec 31, 2025
64f2f29
API: libcrmcommon: xml_create_patchset() source argument is now const
nrwahl2 Dec 31, 2025
c4d0496
Refactor: libcib: Clarify patchset_cib variable
nrwahl2 Dec 31, 2025
0186705
Refactor: libcib: Assert on NULL diff in cib_perform_op()
nrwahl2 Jan 1, 2026
55a1712
Refactor: libcrmcommon: Drop redundant check in xml_create_patchset_v2()
nrwahl2 Jan 1, 2026
36913c6
Refactor: libcib: goto done if *diff is NULL in cib_perform_op()
nrwahl2 Jan 1, 2026
85693c5
Log: libcib: Drop logging XML changes and raw patchset in cib_perform_op
nrwahl2 Jan 1, 2026
77bc530
Refactor: libcib: Move pcmk__xml_commit_changes() call
nrwahl2 Jan 1, 2026
1e63e7a
Refactor: based: Drop dead code for PCMK__XA_CIB_UPDATE
nrwahl2 Jan 2, 2026
0ba24d5
Refactor: based: Drop based_process_apply_patch, send_sync_request, etc.
nrwahl2 Jan 2, 2026
f5c7bf1
Refactor: based: Drop based_process_replace()
nrwahl2 Jan 2, 2026
bc85ed3
Refactor: libcib, based: Drop cib__op_sync_to_one and related things
nrwahl2 Jan 2, 2026
519b4f3
Refactor: libcib: Rename *_sync_to_all to *_sync
nrwahl2 Jan 2, 2026
b12f8cb
Fix: libcib: Don't convert -pcmk_err_diff_resync to pcmk_ok
nrwahl2 Jan 2, 2026
0d84eeb
Feature: libcrmcommon: xml_apply_patchset doesn't return diff_resync err
nrwahl2 Jan 2, 2026
35860a9
Log: controller: Don't treat patchset-apply errors as OK
nrwahl2 Jan 2, 2026
a6385b3
Refactor: based: Drop pcmk_rc_diff_resync from switch
nrwahl2 Jan 2, 2026
b284af4
Log: based: Don't log specially for PCMK__XA_CIB_UPDATE
nrwahl2 Jan 2, 2026
b354a9c
Low: fencer: Refresh CIB in case of old diff
nrwahl2 Jan 2, 2026
53e9f8b
API: libcrmcommon: Deprecate pcmk_rc_diff_resync, pcmk_err_diff_resync
nrwahl2 Jan 2, 2026
8d7d173
Log: based: Don't send entire CIB in ping reply for digest mismatch
nrwahl2 Jan 2, 2026
49304f6
Doc: libcib: Address a comment about possible legacy code
nrwahl2 Jan 2, 2026
c5817e8
Refactor: libcib: Drop cib_perform_op() manage_counters argument
nrwahl2 Jan 2, 2026
2e0a269
Refactor: libcib: Drop op arg from cib__perform_query()/cib_perform_op()
nrwahl2 Jan 2, 2026
8de084c
Refactor: libcib: Drop call_options arg from cib_perform_op()...
nrwahl2 Jan 2, 2026
bb0edc5
Refactor: based: Don't pass type to prepare_input()
nrwahl2 Jan 2, 2026
8344f80
Refactor: libcib: Drop input arg from cib__perform_query/cib_perform_op
nrwahl2 Jan 2, 2026
df77ade
Low: libcib: Move CIB op input transformation to ops that need it
nrwahl2 Jan 2, 2026
8787f69
Refactor: libcib: Drop section arg of cib__perform_query/cib_perform_op
nrwahl2 Jan 2, 2026
86474f8
Refactor: libcib: Move process_replace_xpath() downward
nrwahl2 Jan 2, 2026
bbcdf84
Fix: libcib: Full-CIB replace op no longer segfaults with cib_xpath
nrwahl2 Jan 2, 2026
470055d
Refactor: libcrmcommon: apply_transformation takes xmlDoc * argument
nrwahl2 Jan 2, 2026
6e51099
Refactor: libcrmcommon: apply_upgrade() takes xmlDoc * argument
nrwahl2 Jan 2, 2026
24ad82f
Refactor: libcrmcommon: validate_with() takes xmlDoc * argument
nrwahl2 Jan 2, 2026
377dab4
Refactor: libcrmcommon: validate_with_silent() takes xmlDoc * argument
nrwahl2 Jan 2, 2026
165dbf6
Refactor: libcrmcommon: Drop pcmk__validate_xml() validation argument
nrwahl2 Jan 2, 2026
e67eb46
Refactor: libcib: cib__process_upgrade() keeps same doc
nrwahl2 Jan 2, 2026
1a7a32e
Doc: libcib: Require that cib__op_fn_t does not alter doc private data
nrwahl2 Jan 2, 2026
1ceb4e8
Refactor: libcib: cib_perform_op no longer checks tracking flag post-fn
nrwahl2 Jan 2, 2026
5763f8b
Refactor: libcib: Deduplicate tracing in cib_perform_op()
nrwahl2 Jan 2, 2026
4987cbd
Refactor: libcib: cib_perform_op() takes only one CIB argument
nrwahl2 Jan 2, 2026
de1938a
Refactor: libcib: Drop working_cib variable from cib_perform_op()
nrwahl2 Jan 3, 2026
6b48aa6
Refactor: libcib: Deduplicate enable-ACL and fn call in cib_perform_op()
nrwahl2 Jan 3, 2026
537a6bf
Refactor: libcib: Drop op arg from cib__op_fn_t
nrwahl2 Jan 3, 2026
142a43c
Refactor: libcib: Drop options arg from cib__op_fn_t
nrwahl2 Jan 3, 2026
36b43a3
Refactor: libcib: Drop section arg from cib__op_fn_t
nrwahl2 Jan 3, 2026
70b951c
Refactor: libcib: New cib__get_calldata()
nrwahl2 Jan 3, 2026
29eaa05
Refactor: libcib: New cib__set_calldata()
nrwahl2 Jan 3, 2026
41b8134
Refactor: libcib: Call xml_apply_patchset() in cib_apply_patch_event()
nrwahl2 Jan 3, 2026
86d4648
Refactor: libcib: Drop input arg from cib__op_fn_t
nrwahl2 Jan 3, 2026
ce0af1a
Refactor: libcib: Drop input argument from cib_perform_op helpers
nrwahl2 Jan 3, 2026
fe12c8f
Refactor: libcib: Reduce number of arguments in cib_ops.c
nrwahl2 Jan 3, 2026
4ca9576
Log: based: Drop redundant log from cib_process_command()
nrwahl2 Jan 3, 2026
62c2cf5
Refactor: based: Drop redundant cib_process_command() config_changed set
nrwahl2 Jan 3, 2026
e7ce6ec
Refactor: based: Unindent block of cib_process_command()
nrwahl2 Jan 3, 2026
b7e7740
Refactor: based: Unindent some of process_ping_reply()
nrwahl2 Jan 3, 2026
1b2ded9
Refactor: based: Unindent rest of process_ping_reply()
nrwahl2 Jan 3, 2026
c5785ba
Refactor: based: Convert ping_seq to long long
nrwahl2 Jan 3, 2026
ac53e5a
Low: based: Ignore ping reply if we're no longer DC
nrwahl2 Jan 3, 2026
7e037e3
Refactor: based: Unindent outermost else block in based_process_upgrade
nrwahl2 Jan 4, 2026
ba68ed8
Refactor: based: Unindent pcmk_rc_ok section of based_process_upgrade()
nrwahl2 Jan 4, 2026
6eee600
Refactor: based: Don't set answer to NULL in cib__op_fn_t functions
nrwahl2 Jan 4, 2026
2454a16
Refactor: libcib: Rename cib__perform_query() to cib__perform_op_ro()
nrwahl2 Jan 4, 2026
7e3b874
Refactor: libcib: Rename cib_perform_op() to cib__perform_op_rw()
nrwahl2 Jan 4, 2026
9e11526
Refactor: based: Don't free remote_versions in process_ping_reply()
nrwahl2 Jan 4, 2026
711c3b7
Refactor: based: Assume the_cib is not NULL
nrwahl2 Jan 4, 2026
bdf2208
Doc: based, libcib: Clarify cib__op_attr_modifies
nrwahl2 Jan 4, 2026
9b43293
Doc: based: Add Doxygen for process_ping_reply()
nrwahl2 Jan 4, 2026
f8db65d
Refactor: based: sync_our_cib() takes const argument
nrwahl2 Jan 4, 2026
097c2c0
Low: based: Free ping_digest on exit
nrwahl2 Jan 4, 2026
479e64b
Refactor: based: Minor reorganization of cib_process_command()
nrwahl2 Jan 4, 2026
fecef51
Feature: libcrmcommon: Assert on memory error in mainloop_add_fd()
nrwahl2 Jan 6, 2026
9add533
Refactor: libcrmcommon: Unindent mainloop_add_fd()
nrwahl2 Jan 6, 2026
7f50962
Low: based: Free remote client if TLS session creation fails
nrwahl2 Jan 6, 2026
e8fd61a
Refactor: based: Drop qb_ipcs_stats_get() call
nrwahl2 Jan 6, 2026
571a879
Low: based: Drop remote clients during shutdown
nrwahl2 Jan 6, 2026
5586ec2
Refactor: based: Use pcmk__drop_all_clients() in based_shutdown()
nrwahl2 Jan 4, 2026
450079f
Refactor: based: Assume dropped remote clients are freed
nrwahl2 Jan 6, 2026
40f6fcc
Refactor: based: Inline initiate_exit()
nrwahl2 Jan 6, 2026
3ab85a4
Refactor: based: create_cib_reply/based_diff_notify take standard rc
nrwahl2 Jan 4, 2026
f6a4305
Refactor: based: based_diff_notify() takes request argument
nrwahl2 Jan 4, 2026
03d32af
Refactor: based: create_cib_reply() takes request argument
nrwahl2 Jan 4, 2026
482bd3d
Doc: based: Drop irrelevant comment about legacy mode
nrwahl2 Jan 4, 2026
b389c87
Refactor: based: Unindent do_local_notify() call
nrwahl2 Jan 4, 2026
f2eb84f
Refactor: based: Guard create_cib_reply() call with !cib_discard_reply
nrwahl2 Jan 4, 2026
806f967
Refactor: based: Move privilege check to based_process_request()
nrwahl2 Jan 4, 2026
f9915fe
Refactor: based: Drop NULL-check of reply from cib_process_command()
nrwahl2 Jan 4, 2026
a53ca16
Refactor: based: Drop based_process_request last cib_discard_reply check
nrwahl2 Jan 4, 2026
ca44bb8
Refactor: libcib: Use done label in cib__perform_op_ro()
nrwahl2 Jan 4, 2026
cc6ed21
Low: libcib: Avoid memory leak in processing CIB file commit transaction
nrwahl2 Jan 4, 2026
e28006e
Refactor: libcib: Avoid unnecessary copy in process_request()
nrwahl2 Jan 5, 2026
9bd0875
Refactor: libcib: Don't copy output that's part of the current CIB's doc
nrwahl2 Jan 5, 2026
953a1c4
Refactor: libcib: Minor cib__perform_op_ro() cleanup
nrwahl2 Jan 5, 2026
a886492
Refactor: based: based_process_request gets last create_cib_reply check
nrwahl2 Jan 5, 2026
28a5054
Refactor: based: Pull read-only ops out of cib_process_command()
nrwahl2 Jan 5, 2026
9b47dc3
Low: based: Free digest_timer on exit
nrwahl2 Jan 5, 2026
9250f2f
Refactor: based: Move notify to done section in based_perform_op_rw()
nrwahl2 Jan 5, 2026
78dc14f
Refactor: based: Unindent successful common case in based_perform_op_rw
nrwahl2 Jan 5, 2026
f242699
Refactor: based: Drop dead output log msg for pcmk_rc_schema_validation
nrwahl2 Jan 5, 2026
f375412
Fix: based: Fix handling of intermediate transaction results
nrwahl2 Jan 5, 2026
e39d8e2
Log: based: Drop redundant log in based_process_request()
nrwahl2 Jan 5, 2026
45d56ce
Refactor: based: Unindent "if (process)" block of based_process_request
nrwahl2 Jan 5, 2026
5185983
Refactor: based: Don't call option parser when cib_transaction is set
nrwahl2 Jan 5, 2026
8606a2f
Refactor: based: Drop needs_forward variable
nrwahl2 Jan 5, 2026
392857b
API: libcib: Deprecate cib_api_operations_t:sync
nrwahl2 Jan 5, 2026
b97a0b5
Refactor: based: Minor easy changes to parse_peer_options()
nrwahl2 Jan 5, 2026
6868418
Refactor: based: Move two parse_peer_options() early returns upward
nrwahl2 Jan 5, 2026
f4492a4
Refactor: based: Drop legacy code from parse_peer_options()
nrwahl2 Jan 5, 2026
120622e
Refactor: based: Move is_reply block to where it's used
nrwahl2 Jan 5, 2026
f983926
Refactor: based: Drop redundant check for upgrade RC
nrwahl2 Jan 5, 2026
e2aee62
Refactor: based: Move early return to beginning of upgrade block
nrwahl2 Jan 5, 2026
27b89fa
Refactor: based: Drop skip_is_reply label
nrwahl2 Jan 5, 2026
7fcc44a
Refactor: based: parse_local_options() -> log_local_options()
nrwahl2 Jan 5, 2026
9f16068
Refactor: based: Set control variables only if they override defaults
nrwahl2 Jan 5, 2026
a51d0df
Refactor: based: Rename crm_cluster to based_cluster
nrwahl2 Jan 6, 2026
fa8013e
Refactor: libcrmcluster: Allow NULL arg to pcmk_cluster_disconnect()
nrwahl2 Jan 6, 2026
8fa8b05
Refactor: based: Don't create based_cluster if in stand-alone mode
nrwahl2 Jan 6, 2026
8202a69
Refactor: based: New based_ipc_init() and based_ipc.h
nrwahl2 Jan 6, 2026
9e96e24
Refactor: based: New based_ipc_cleanup()
nrwahl2 Jan 6, 2026
55cee45
Low: based: Move based_ipc_cleanup() call to based_terminate()
nrwahl2 Jan 6, 2026
5b85fde
Refactor: based: Functionize remote fd closure in based_remote.c
nrwahl2 Jan 6, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions cts/cli/regression.access_render.exp
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
=#=#=#= Begin test: Configure some ACLs =#=#=#=
=#=#=#= Current cib after: Configure some ACLs =#=#=#=
<cib epoch="2" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="2" num_updates="0">
<configuration>
<crm_config/>
<nodes/>
Expand All @@ -23,7 +23,7 @@
* Passed: cibadmin - Configure some ACLs
=#=#=#= Begin test: Enable ACLs =#=#=#=
=#=#=#= Current cib after: Enable ACLs =#=#=#=
<cib epoch="3" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="3" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -50,7 +50,7 @@
* Passed: crm_attribute - Enable ACLs
=#=#=#= Begin test: An instance of ACLs render (into color) =#=#=#=
<!-- ACLs as evaluated for user tony -->
<cib epoch="3" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="3" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -77,7 +77,7 @@
* Passed: cibadmin - An instance of ACLs render (into color)
=#=#=#= Begin test: An instance of ACLs render (into namespacing) =#=#=#=
<!-- ACLs as evaluated for user tony -->
<pcmk-access-readable:cib epoch="3" num_updates="0" admin_epoch="0" xmlns:pcmk-access-writable="http://clusterlabs.org/ns/pacemaker/access/writable" xmlns:pcmk-access-readable="http://clusterlabs.org/ns/pacemaker/access/readable" xmlns:pcmk-access-denied="http://clusterlabs.org/ns/pacemaker/access/denied">
<pcmk-access-readable:cib admin_epoch="0" epoch="3" num_updates="0" xmlns:pcmk-access-writable="http://clusterlabs.org/ns/pacemaker/access/writable" xmlns:pcmk-access-readable="http://clusterlabs.org/ns/pacemaker/access/readable" xmlns:pcmk-access-denied="http://clusterlabs.org/ns/pacemaker/access/denied">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand Down Expand Up @@ -105,7 +105,7 @@
=#=#=#= Begin test: An instance of ACLs render (into text) =#=#=#=
<!-- ACLs as evaluated for user tony -->
vvv---[ READABLE ]---vvv
<cib epoch="3" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="3" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand Down
74 changes: 37 additions & 37 deletions cts/cli/regression.acls.exp

Large diffs are not rendered by default.

24 changes: 12 additions & 12 deletions cts/cli/regression.cibadmin.exp
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
=#=#=#= Begin test: Validate CIB =#=#=#=
<cib epoch="4" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -17,7 +17,7 @@
<status/>
</cib>
=#=#=#= Current cib after: Validate CIB =#=#=#=
<cib epoch="4" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -38,7 +38,7 @@
* Passed: cibadmin - Validate CIB
=#=#=#= Begin test: Validate CIB (XML) =#=#=#=
<pacemaker-result api-version="X" request="cibadmin --output-as=xml -Q">
<output><![CDATA[<cib epoch="4" num_updates="0" admin_epoch="0">
<output><![CDATA[<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -59,7 +59,7 @@
<status code="0" message="OK"/>
</pacemaker-result>
=#=#=#= Current cib after: Validate CIB (XML) =#=#=#=
<cib epoch="4" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand All @@ -79,20 +79,20 @@
=#=#=#= End test: Validate CIB (XML) - OK (0) =#=#=#=
* Passed: cibadmin - Validate CIB (XML)
=#=#=#= Begin test: Digest calculation =#=#=#=
9130d6f39c2b83bd032a00e76621508c
1f3492630cde57d6b7ee45de4d390469
=#=#=#= End test: Digest calculation - OK (0) =#=#=#=
* Passed: cibadmin - Digest calculation
=#=#=#= Begin test: Digest calculation (XML) =#=#=#=
<pacemaker-result api-version="X" request="cibadmin --output-as=xml -5 -p">
<md5-sum digest="9130d6f39c2b83bd032a00e76621508c"/>
<md5-sum digest="1f3492630cde57d6b7ee45de4d390469"/>
<status code="0" message="OK"/>
</pacemaker-result>
=#=#=#= End test: Digest calculation (XML) - OK (0) =#=#=#=
* Passed: cibadmin - Digest calculation (XML)
=#=#=#= Begin test: Require --force for CIB erasure =#=#=#=
cibadmin: The supplied command is considered dangerous. To prevent accidental destruction of the cluster, the --force flag is required in order to proceed.
=#=#=#= Current cib after: Require --force for CIB erasure =#=#=#=
<cib epoch="4" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand Down Expand Up @@ -120,7 +120,7 @@ cibadmin: The supplied command is considered dangerous. To prevent accidental de
</status>
</pacemaker-result>
=#=#=#= Current cib after: Require --force for CIB erasure (XML) =#=#=#=
<cib epoch="4" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="4" num_updates="0">
<configuration>
<crm_config>
<cluster_property_set id="cib-bootstrap-options">
Expand Down Expand Up @@ -149,7 +149,7 @@ cibadmin: The supplied command is considered dangerous. To prevent accidental de
=#=#=#= End test: Allow CIB erasure with --force (XML) - OK (0) =#=#=#=
* Passed: cibadmin - Allow CIB erasure with --force (XML)
=#=#=#= Begin test: Query CIB =#=#=#=
<cib epoch="1" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="1" num_updates="0">
<configuration>
<crm_config/>
<nodes/>
Expand All @@ -159,7 +159,7 @@ cibadmin: The supplied command is considered dangerous. To prevent accidental de
<status/>
</cib>
=#=#=#= Current cib after: Query CIB =#=#=#=
<cib epoch="1" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="1" num_updates="0">
<configuration>
<crm_config/>
<nodes/>
Expand All @@ -172,7 +172,7 @@ cibadmin: The supplied command is considered dangerous. To prevent accidental de
* Passed: cibadmin - Query CIB
=#=#=#= Begin test: Query CIB (XML) =#=#=#=
<pacemaker-result api-version="X" request="cibadmin --output-as=xml -Q">
<output><![CDATA[<cib epoch="1" num_updates="0" admin_epoch="0">
<output><![CDATA[<cib admin_epoch="0" epoch="1" num_updates="0">
<configuration>
<crm_config/>
<nodes/>
Expand All @@ -185,7 +185,7 @@ cibadmin: The supplied command is considered dangerous. To prevent accidental de
<status code="0" message="OK"/>
</pacemaker-result>
=#=#=#= Current cib after: Query CIB (XML) =#=#=#=
<cib epoch="1" num_updates="0" admin_epoch="0">
<cib admin_epoch="0" epoch="1" num_updates="0">
<configuration>
<crm_config/>
<nodes/>
Expand Down
Loading