Also show memory limit for samples on team submission page #3302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was requested at SEERC and I think it makes sense in general. Also updated the logic to only show these limits when `show_limits_on_team_page` is set.
Algotester does this so we needed it for SEERC and I think having this as an option can make sense.
vmcj
reviewed
Dec 16, 2025
| <th>Runtime</th> | ||
| <td>{{ judgingRun.runtime }} sec</td> | ||
| </tr> | ||
| {% if showLimits %} |
Member
There was a problem hiding this comment.
I prefer to not have this option, and first come up with a good reason why this shouldn´t be public.
If there is a good reason we should also add tests for this to make sure that we don´t expose that information, for now I miss the change to also expose this in the API to keep those in line.
Member
Author
There was a problem hiding this comment.
I'm fine always doing it but if we have that setting for limits turned of I think it's weird.
As for the API, I'm fine adding the memory limit there as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm open to discussing these changes, since they might not be preferred by everyone.
I am in favor of the first change for sure (since teams could measure this on their own machine anyway). The second might be more controversial.