Skip to content

Conversation

@DinneK
Copy link

@DinneK DinneK commented Jun 10, 2025

module-name: Project/Agency Card Load with the inclusion of legacyJSON

Problem

New legacy-codegov.json added to repository, new schema does not quite match current schema. Both data sets are necessary and need to be reconciled in order for proper agency and project card load on the frontend.

Solution

In codegovData.js add appropriate properties and error handling for any missing data in old code. In assets/_common/js/filters.js add error handling for languages.

Result

All cards now load correctly

Note:

There are almost 8000 cards currently, causing slow load and reaction times.

Test Plan

Test in browser

Next Steps:

  • Add images for agencies
  • Add filter handling for usageTypes, and possibly for maturity model and fisma levels
  • Caching and/or pagination

sachin-panayil and others added 18 commits June 4, 2025 10:40
Signed-off-by: Sachin Panayil <sachinpanayil01@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Sachin Panayil <sachinpanayil01@gmail.com>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
… add a util function for merging the data from differant indexes

Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Home Page: Fixed button urls
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
@DinneK DinneK self-assigned this Jun 10, 2025
@DinneK DinneK added the enhancement New feature or request label Jun 10, 2025
@decause-gov
Copy link

@sachin-panayil and @IsaacMilarky plz give this a review to help understand how it fits in with our legacy metadata updater loops.

@DinneK DinneK merged commit fa34fd4 into dev Jun 13, 2025
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants