forked from DSACMS/ospo-guide
-
Notifications
You must be signed in to change notification settings - Fork 2
Add legacy code to front end #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sachin Panayil <sachinpanayil01@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Sachin Panayil <sachinpanayil01@gmail.com>
Legacy Index Generator
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Fix Input to Fetch Script
… add a util function for merging the data from differant indexes Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Home Page: Fixed button urls
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Signed-off-by: Isaac Milarsky <imilarsky@gmail.com>
Integrate Fetch Scripts
Signed-off-by: Dinne Kopelevich <dinne.kopelevich@gsa.gov>
|
@sachin-panayil and @IsaacMilarky plz give this a review to help understand how it fits in with our legacy metadata updater loops. |
sachin-panayil
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
module-name: Project/Agency Card Load with the inclusion of legacyJSON
Problem
New
legacy-codegov.jsonadded to repository, new schema does not quite match current schema. Both data sets are necessary and need to be reconciled in order for proper agency and project card load on the frontend.Solution
In
codegovData.jsadd appropriate properties and error handling for any missing data in old code. Inassets/_common/js/filters.jsadd error handling for languages.Result
All cards now load correctly
Note:
There are almost 8000 cards currently, causing slow load and reaction times.
Test Plan
Test in browser
Next Steps: