feat: migrate header, sidebar, maincontent inset to shadcn components #180
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <script lang="ts" setup> | ||
| import type { HTMLAttributes } from 'vue' | ||
| const props = defineProps<{ | ||
| class?: HTMLAttributes['class'] | ||
| }>() | ||
| </script> | ||
|
|
||
| <template> | ||
| <nav | ||
| aria-label="breadcrumb" | ||
| data-slot="breadcrumb" | ||
| :class="props.class" | ||
| > | ||
| <slot /> | ||
| </nav> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| <script lang="ts" setup> | ||
| import { cn } from '@frontend/lib/utils' | ||
| import { MoreHorizontal } from 'lucide-vue-next' | ||
| import type { HTMLAttributes } from 'vue' | ||
|
|
||
| const props = defineProps<{ | ||
| class?: HTMLAttributes['class'] | ||
| }>() | ||
| </script> | ||
|
|
||
| <template> | ||
| <span | ||
| data-slot="breadcrumb-ellipsis" | ||
| role="presentation" | ||
| aria-hidden="true" | ||
| :class="cn('flex size-9 items-center justify-center', props.class)" | ||
| > | ||
| <slot> | ||
| <MoreHorizontal class="size-4" /> | ||
| </slot> | ||
| <span class="sr-only">More</span> | ||
| </span> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <script lang="ts" setup> | ||
| import { cn } from '@frontend/lib/utils' | ||
| import type { HTMLAttributes } from 'vue' | ||
|
|
||
| const props = defineProps<{ | ||
| class?: HTMLAttributes['class'] | ||
| }>() | ||
| </script> | ||
|
|
||
| <template> | ||
| <li | ||
| data-slot="breadcrumb-item" | ||
| :class="cn('inline-flex items-center gap-1.5', props.class)" | ||
| > | ||
| <slot /> | ||
| </li> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <script lang="ts" setup> | ||
| import { cn } from '@frontend/lib/utils' | ||
| import type { PrimitiveProps } from 'reka-ui' | ||
| import { Primitive } from 'reka-ui' | ||
| import type { HTMLAttributes } from 'vue' | ||
|
|
||
| const props = withDefaults(defineProps<PrimitiveProps & { class?: HTMLAttributes['class'] }>(), { | ||
| as: 'a', | ||
| }) | ||
| </script> | ||
|
|
||
| <template> | ||
| <Primitive | ||
| data-slot="breadcrumb-link" | ||
| :as="as" | ||
| :as-child="asChild" | ||
| :class="cn('hover:text-foreground transition-colors', props.class)" | ||
| > | ||
| <slot /> | ||
| </Primitive> | ||
| </template> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| <script lang="ts" setup> | ||
| import { cn } from '@frontend/lib/utils' | ||
| import type { HTMLAttributes } from 'vue' | ||
|
|
||
| const props = defineProps<{ | ||
| class?: HTMLAttributes['class'] | ||
| }>() | ||
| </script> | ||
|
|
||
| <template> | ||
| <ol | ||
| data-slot="breadcrumb-list" | ||
| :class="cn('text-muted-foreground flex flex-wrap items-center gap-1.5 text-sm break-words sm:gap-2.5', props.class)" | ||
| > | ||
| <slot /> | ||
| </ol> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,20 @@ | ||||||||||||||||||||||||||||||||||
| <script lang="ts" setup> | ||||||||||||||||||||||||||||||||||
| import { cn } from '@frontend/lib/utils' | ||||||||||||||||||||||||||||||||||
| import type { HTMLAttributes } from 'vue' | ||||||||||||||||||||||||||||||||||
| const props = defineProps<{ | ||||||||||||||||||||||||||||||||||
| class?: HTMLAttributes['class'] | ||||||||||||||||||||||||||||||||||
| }>() | ||||||||||||||||||||||||||||||||||
| </script> | ||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||
| <template> | ||||||||||||||||||||||||||||||||||
| <span | ||||||||||||||||||||||||||||||||||
| data-slot="breadcrumb-page" | ||||||||||||||||||||||||||||||||||
| role="link" | ||||||||||||||||||||||||||||||||||
| aria-disabled="true" | ||||||||||||||||||||||||||||||||||
| aria-current="page" | ||||||||||||||||||||||||||||||||||
| :class="cn('text-foreground font-normal', props.class)" | ||||||||||||||||||||||||||||||||||
| > | ||||||||||||||||||||||||||||||||||
| <slot /> | ||||||||||||||||||||||||||||||||||
| </span> | ||||||||||||||||||||||||||||||||||
|
Comment on lines
+11
to
+19
There was a problem hiding this comment. Fix incorrect ARIA semantics for breadcrumb page. The current breadcrumb page should not use Apply this diff to fix the accessibility issue: <span
data-slot="breadcrumb-page"
- role="link"
- aria-disabled="true"
aria-current="page"
:class="cn('text-foreground font-normal', props.class)"
>📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||||||||||||||||
| </template> | ||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| <script lang="ts" setup> | ||
| import { cn } from '@frontend/lib/utils' | ||
| import { ChevronRight } from 'lucide-vue-next' | ||
| import type { HTMLAttributes } from 'vue' | ||
|
|
||
| const props = defineProps<{ | ||
| class?: HTMLAttributes['class'] | ||
| }>() | ||
| </script> | ||
|
|
||
| <template> | ||
| <li | ||
| data-slot="breadcrumb-separator" | ||
| role="presentation" | ||
| aria-hidden="true" | ||
| :class="cn('[&>svg]:size-3.5', props.class)" | ||
| > | ||
| <slot> | ||
| <ChevronRight /> | ||
| </slot> | ||
| </li> | ||
| </template> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| export { default as Breadcrumb } from './Breadcrumb.vue' | ||
| export { default as BreadcrumbEllipsis } from './BreadcrumbEllipsis.vue' | ||
| export { default as BreadcrumbItem } from './BreadcrumbItem.vue' | ||
| export { default as BreadcrumbLink } from './BreadcrumbLink.vue' | ||
| export { default as BreadcrumbList } from './BreadcrumbList.vue' | ||
| export { default as BreadcrumbPage } from './BreadcrumbPage.vue' | ||
| export { default as BreadcrumbSeparator } from './BreadcrumbSeparator.vue' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Props scoping bug:
as/asChildare undefined in template.You created
props = defineProps(...)but referenceasandasChilddirectly. Useprops.as/props.asChild(or destructure viatoRefs).Alternatively:
📝 Committable suggestion
🤖 Prompt for AI Agents