Skip to content

Fix for null entries in PlayerPreparesEnchantScriptEvent #2799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Remasuri wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix for null entries in PlayerPreparesEnchantScriptEvent #2799

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1447b0e
Fix for null entries in PlayerPreparesEnchantScriptEvent
Remasuri Dec 13, 2025
9073cb7
Fix for null entries in PlayerPreparesEnchantScriptEvent
Remasuri Dec 13, 2025
fca6ee7
Formatting fix
Remasuri Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...c/main/java/com/denizenscript/denizen/events/player/PlayerPreparesEnchantScriptEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,10 @@ public boolean applyDetermination(ScriptPath path, ObjectTag determinationObj) {
}
for (int i = 0; i < offers.size(); i++) {
MapTag map = MapTag.getMapFor(offers.getObject(i), getTagContext(path));
if (map.isEmpty()){
Copy link
Member

@tal5 tal5 Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing another space here - generally we recommend using an IDE like Intellji IDEA which can help with the formatting/do it for you, a lot easier than managing it manually.

event.getOffers()[i] = null;
continue;
}
event.getOffers()[i].setCost(map.getElement("cost").asInt());
EnchantmentTag enchantment = map.getObjectAs("enchantment_type", EnchantmentTag.class, getTagContext(path));
if (enchantment == null) {
Expand Down Expand Up @@ -108,6 +112,10 @@ public ObjectTag getContext(String name) {
case "offers":
ListTag output = new ListTag();
for (EnchantmentOffer offer : event.getOffers()) {
if (offer == null) {
output.addObject(new MapTag());
continue;
}
MapTag map = new MapTag();
map.putObject("cost", new ElementTag(offer.getCost()));
map.putObject("enchantment", new ElementTag(offer.getEnchantment().getKey().getKey()));
Expand Down