chore: add none check for sse client in config_manager #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes an AttributeError that occurred when attempting to call a non-existent is_connected() method on the SSEClient object. The fix replaces the problematic method call with two alternative checks: verifying that the client is not None and confirming that the read thread is alive.
Key Changes:
- Removed the non-existent
is_connected()method call on SSEClient - Added a check for
client is Noneto handle cases where the SSE client hasn't been initialized - Added a check for
read_thread.is_alive()to verify the SSE connection thread is running
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsalaber
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to address the debug log:
DEBUG:devcycle_python_sdk.managers.sse_manager:DevCycle: failed to read SSE message: 'SSEClient' object has no attribute 'is_connected'