IES updates #965
Open
IES updates #965
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
small change to make sure `ditt` doesn't autodelete
…ubresource bitflags to not trigger asserts, update examples_tests submodule
…experimental, no real validation), update examples_tests submodule
…arguments in json payload, CI should pass now
…ate examples_tests
…ODO on how to improve it even more
… with GPU converter, encode to EF_A2R10G10B10_UNORM_PACK32, update examples_tests submodule
…hlsl/pc.hlsl to allow me precompile unified uber shader, a little formatting, update examples_tests submodule
… both cpp and hlsl
…add sample function overload to sampler.hlsl, create include/nbl/builtin/hlsl/ies/texture.hlsl to share texel write method between C++ & HLSL (the correct one including blending and corner sampling) TODO: need to update IES viewer example to compile again and clean bindings a bit (keep only octahedral image to write and sample from + add new ies::Texture::SInfo)
…sts & use NBL_CONST_MEMBER_FUNC, update examples_tests submodule
AnastaZIuk
commented
Dec 12, 2025
| // ISOTROPIC_BITS = 0b011, texture to sample is Nx1, pretend v=middle always , and make u REPEAT or CLAMP_TO_BORDER | ||
| // FULL_THETA_BIT = 0b100, handle truncated domain and rotate by 45 degrees for anisotropic | ||
| // (certain combos wont work like 90 degree 2 symmetry domain & half theta), it really needs to be an 8 case label thing explicitly enumerated | ||
| vec2 nbl_glsl_IES_convert_dir_to_uv(vec3 dir, vec2 halfMinusHalfPixel) |
Member
Author
There was a problem hiding this comment.
TODO: forgot to wipe, not used anymore
Member
Author
There was a problem hiding this comment.
EDIT: file to remove but leaving it due to reference in material compiler glsl
| float sum = dot(vec3(1.0f), abs(dir)); | ||
| // TODO: when rewriting to HLSL this is not IES namespace or folder, this should be octahedral mapping sitting somewhere where the spherical/polar sits | ||
| // NOTE: I changed it to return NDC [-1,1]^2 instead of UV coords [0,1]^2 | ||
| vec2 nbl_glsl_TODOnamespace_octahedral_mapping(vec3 dir) |
Member
Author
There was a problem hiding this comment.
TODO: forgot to wipe, not used anymore
Member
Author
There was a problem hiding this comment.
EDIT: file to remove but leaving it due to reference in material compiler glsl
…iltins API to support config-genex, fix .spv custom command it was building all configs per single config (and embedding all 3 into single archive)
…luded in headers, not exported and its private interface actually they might be installed but then shall be exported and it requires polishing what content they include as they should hide all info about keys to keep our install single prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.