Skip to content

Conversation

@frankieyan
Copy link
Member

@frankieyan frankieyan commented Nov 1, 2025

Short description

This updates @doist/eslint-config to v12.0, which contains eslint-plugin-react-hooks v7.0

Reference: https://github.com/Doist/eslint-config/pull/131

Important

After testing with yalc, we're not able to import the JsxRuntime from React in Reactist when pulled into Todoist, as the exported members from jsx-runtime.js are different, probably due to different major versions of React being used in Reactist vs Todoist.

I'm continuing on the eslint config update in #982, and we can consider bringing in the runtime again after dropping React 17 support, which will require updating Storybook.

Test plan

  • In the TextField component's story, change the maxLength prop and verify that it is respected, and an indicator is rendered
  • In the Modal component's story, verify that the modal's content receives focus on first render, rather than the close button. Then, verify that you can traverse to the close button via the keyboard
  • In the KeyCapturer component's story, verify that the actions tab show the appropriate key events
    • Switch to either a Japanese, Korean, or Chinese input method, enter composition mode (e.g. cmd + space then start typing) and press enter. The enter key's event should not be logged until composition mode ends

@frankieyan frankieyan requested review from a team and nats12 and removed request for a team November 1, 2025 05:55
@frankieyan frankieyan added the 🙋 Ask PR Used for PRs that need a review before merging. label Nov 1, 2025
@frankieyan frankieyan changed the title chore: Bump eslint-related dependencies and fix errors chore: Bump eslint-related dependencies, enable jsx runtime Nov 2, 2025
@frankieyan frankieyan closed this Nov 2, 2025
@frankieyan frankieyan deleted the frankie/update-eslint-dependencies branch November 12, 2025 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🙋 Ask PR Used for PRs that need a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants