chore: Bump eslint-related dependencies, enable jsx runtime #979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This updates @doist/eslint-config to v12.0, which contains eslint-plugin-react-hooks v7.0
Reference: https://github.com/Doist/eslint-config/pull/131
Important
After testing with yalc, we're not able to import the JsxRuntime from React in Reactist when pulled into Todoist, as the exported members from jsx-runtime.js are different, probably due to different major versions of React being used in Reactist vs Todoist.
I'm continuing on the eslint config update in #982, and we can consider bringing in the runtime again after dropping React 17 support, which will require updating Storybook.
Test plan
TextFieldcomponent's story, change themaxLengthprop and verify that it is respected, and an indicator is renderedModalcomponent's story, verify that the modal's content receives focus on first render, rather than the close button. Then, verify that you can traverse to the close button via the keyboardKeyCapturercomponent's story, verify that the actions tab show the appropriate key events