Skip to content

Conversation

@laraPPr
Copy link
Collaborator

@laraPPr laraPPr commented May 2, 2025

Also needed to fix the tests to take the ordering into account

@laraPPr laraPPr mentioned this pull request May 2, 2025
1 task
@laraPPr
Copy link
Collaborator Author

laraPPr commented May 2, 2025

Tested new workflow here, laraPPr#1. I hope the workflow will be triggered for the update available scripts pr once this pr gets merged. I'm not sure why it is not triggering the workflow in this pr.

@laraPPr
Copy link
Collaborator Author

laraPPr commented May 2, 2025

And the tests of the available_software.py also do not seem to be running but I ran them locally.

@laraPPr
Copy link
Collaborator Author

laraPPr commented May 2, 2025

The test for the changed available_software.py script are ran see https://github.com/EESSI/docs/actions/runs/14799376763

@laraPPr laraPPr requested a review from bedroge May 7, 2025 19:45
@Neves-P Neves-P self-requested a review May 14, 2025 08:02
Copy link
Member

@Neves-P Neves-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laraPPr, looks good! I just made a small suggestion on the docs of a function in the docstring. Feel free to reject if you prefer the info to stay as is (since you already have code comments) 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow didn't run (as expected, given run the conditions), but it did run in @laraPPr's branch and works well: https://github.com/laraPPr/EESSI_docs/actions/runs/14799375963, so it's safe to assume it will run well when the conditions are met in the target branch.

Co-authored-by: Pedro Santos Neves <10762799+Neves-P@users.noreply.github.com>
@laraPPr
Copy link
Collaborator Author

laraPPr commented May 14, 2025

The linter is failing on yo docstring

Co-authored-by: Lara Ramona Peeters <49882639+laraPPr@users.noreply.github.com>
@Neves-P
Copy link
Member

Neves-P commented May 14, 2025

The linter is failing on yo docstring

Sorry about that! Pushed your suggestions now, hopefully it passes now 👍

Copy link
Member

@Neves-P Neves-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Neves-P Neves-P merged commit ff131ff into EESSI:main May 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants