Skip to content

Conversation

@lvoliveira
Copy link
Contributor

@lvoliveira lvoliveira commented Oct 14, 2025

  • Use pixi as local development tool replacing conda.
  • Use pixi on CI instead of tox to keep the same tool locally on on CI
  • Add lint job to ensure linting rules are being respected
  • Add a build and test-build step to run on every PR instead of only run it on the deploy steps (That is run only on the tag for release)
  • Modernize build to avoid calling setup.py directly. (See Why you shouldn't invoke setup.py directly )
  • Remove completely broken module swagger_spec.py‎. Typing there were also completely broken.

@lvoliveira lvoliveira force-pushed the fb-RFDAP-8594-use-pixi branch 6 times, most recently from 6725ccc to e3edc6e Compare October 15, 2025 17:09
Build and publish a test version of the package to TestPypi on every
build.
@lvoliveira lvoliveira force-pushed the fb-RFDAP-8594-use-pixi branch from ec2428f to 3349008 Compare October 17, 2025 19:34
@sonarqubecloud
Copy link

Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

I think the documentation needs reviewing too (for example CONTRIBUTING.rst, CHANGELOG.rst, etc.)

Copy link
Contributor

@lincrosenbach lincrosenbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor 👍🏼

@nicoddemus
Copy link
Member

Just to comment: in general we are moving public, standalone projects like this to uv instead, but of course pixi is OK too.

@lvoliveira
Copy link
Contributor Author

lvoliveira commented Oct 20, 2025

Nice work!

I think the documentation needs reviewing too (for example CONTRIBUTING.rst, CHANGELOG.rst, etc.)

Humm, any specific suggestion? CONTRIBUTING.rst I've already updated and CHANGELOG.rst we use to update on the release-<version> branch for releasing.

@nicoddemus
Copy link
Member

Humm, any specific suggestion? CONTRIBUTING.rst I've already updated and CHANGELOG.rst we use to update on the release- branch for releasing.

No it looks good, I missed the changes in CONTRIBUTING the first time, sorry.

@lvoliveira lvoliveira merged commit f86976b into master Oct 21, 2025
22 checks passed
@lvoliveira lvoliveira deleted the fb-RFDAP-8594-use-pixi branch October 21, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants