Use currencyConfig.getTokenId instead of addCustomToken hack
#5267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jon-edge
force-pushed
the
jon/fix/dup-custom-tokens
branch
4 times, most recently
from
ec99f0a to
60b8af6
Compare
peachbits
requested changes
Sep 20, 2024
Contributor
peachbits
left a comment
peachbits
left a comment
There was a problem hiding this comment.
One tiny change requested, otherwise looks good
| setLocation(location => { | ||
| const out = new Map(location) | ||
| out.set(item.key, value) | ||
| out.set(item.key, value.replace(/[\n\s]/g, '')) |
Contributor
There was a problem hiding this comment.
This is redundant and can be simplified to /\s/g
peachbits
approved these changes
Sep 21, 2024
Jon-edge
force-pushed
the
jon/fix/dup-custom-tokens
branch
2 times, most recently
from
44a6b5e to
e84bf5f
Compare
Jon-edge
force-pushed
the
jon/fix/dup-custom-tokens
branch
from
e84bf5f to
b393af3
Compare
Also remove case of overriding a built-in tokenId
Jon-edge
force-pushed
the
jon/fix/dup-custom-tokens
branch
from
b393af3 to
e38c470
Compare
Common paste issue
Jon-edge
force-pushed
the
jon/fix/dup-custom-tokens
branch
from
e38c470 to
4765d7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove case of overriding a built-in tokenId
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
Requirements
If you have made any visual changes to the GUI. Make sure you have: