-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Fix/65341 - Emoji picker aligns to top when navigating with keyboard open #66853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppWhatsApp.Video.2025-07-28.at.15.04.04.mp4Android: mWeb ChromeiOS: HybridAppScreen.Recording.2025-07-28.at.15.09.16.mov |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.1.87-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.1.87-14 🚀
|
| setEmojiPopoverAnchorPosition({ | ||
| horizontal: value.horizontal, | ||
| vertical: value.vertical, | ||
| KeyboardUtils.dismiss().then(() => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.



Explanation of Change
Fixed Issues
$ #65341
PROPOSAL: #65341 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4