-
Notifications
You must be signed in to change notification settings - Fork 3.5k
[HOLD] [Release 3] [Domain Control] Report suspicious activity #78372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[HOLD] [Release 3] [Domain Control] Report suspicious activity #78372
Conversation
…page # Conflicts: # src/ROUTES.ts # src/SCREENS.ts # src/libs/Navigation/linkingConfig/RELATIONS/DOMAIN_TO_RHP.ts # src/pages/domain/Admins/DomainAdminsPage.tsx
…page # Conflicts: # src/ONYXKEYS.ts # src/ROUTES.ts # src/SCREENS.ts # src/pages/domain/Admins/DomainAdminsPage.tsx # src/selectors/Domain.ts # src/types/onyx/index.ts
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
Part for Domain Control project. This PR adds revoking admin access with GBR and RBR flows.
Based on the design doc & discussion it resembles Report Suspicious Activity from the Settings/Account page.
For now blocked by #77872
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-12-23.at.16.58.56.mov