Skip to content

Conversation

@TrafficConeOfSchooling
Copy link

@TrafficConeOfSchooling TrafficConeOfSchooling commented Dec 16, 2025

Description of the proposed changes

I have resized 3 of the normal textures for the ancient earth props to 512 x 512:
eg_bush01_normalsTS.dds
eg_bush02_normalsTS.dds
eg_bush03_normalsTS.dds
These textures were originally at size 518 x 518 which is incompatible with BC3 texture compression.
image
Hence this error message when the map editor loads the ancient-earth props section.

Testing done on the proposed changes

I took the entire ancient-earth prop folder out of the game files and pasted it into a test map's props folder.
Loading the map folder's props still resulted in the error.
Replacing the 518 x 518 textures with 512 x 512 versions allowed every prop in the map folder to be loaded and used properly.

Checklist

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted texture sizing for 3 prop normal textures to resolve compatibility issues and enable all ancient-earth props to load in the map editor.

✏️ Tip: You can customize this high-level summary in your review settings.

This will allow the FAF map editor to load props from the ancient-earth section. BC3 texture compression requires a multiple of 4 (in texture size) on every prop related texture  for the map editor to load any props from that section.
@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Walkthrough

A changelog entry documenting the resizing of 3 prop normal textures from 518x518 to 512x512 pixels for BC3 texture compression compatibility and FAF map editor compatibility.

Changes

Cohort / File(s) Summary
Changelog entry
changelog/snippets/fix.6982.md
Documents texture dimension fix for prop normal maps to support BC3 compression format and map editor loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through textures fine,
512 by 512, now they align!
Props resized, BC3 blessed,
Ancient earth editors pass the test! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: resizing 3 prop normal textures from 518x518 to 512x512.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description covers the main sections of the template with clear explanation of changes, testing methodology, and a changelog entry, though reviewer requests were not completed.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@TrafficConeOfSchooling TrafficConeOfSchooling changed the title Change 3 prop normal textures from size 518x518 to 512x512 Change 3 prop normal textures from size 518x518 to 512x512 #6982 Dec 16, 2025
@TrafficConeOfSchooling TrafficConeOfSchooling changed the title Change 3 prop normal textures from size 518x518 to 512x512 #6982 Change 3 prop normal textures from size 518x518 to 512x512 Dec 16, 2025
@TrafficConeOfSchooling TrafficConeOfSchooling marked this pull request as ready for review December 16, 2025 23:24
@Garanas
Copy link
Member

Garanas commented Dec 17, 2025

This is a great find 👍 , the game is also unable to process non-power-of-two textures in some area's of the game, such as terrain stratum textures. It rescales the texture internally to the next power-of-two as it tries to load the texture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants