Styling, Client Auth, Version Handshake #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
f-michaut
commented
Aug 23, 2025
f-michaut
commented
- Added clang-tidy + re-styled most of the code
- Split server and peer configs
- Added PreAuthPeer to handle version handshake + auth step
- Added a temporary in-memory KnownPeerStore for auth step
- Remember Configs load filepath to re-use on save by default
- FileType to/from str/streams
- Fix File transfers logic that could sometimes crash
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
09b6907 to
51a95a2
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
51a95a2 to
449e0d2
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
449e0d2 to
3031632
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
3031632 to
3255569
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
3255569 to
180847a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
- Added clang-tidy + re-styled most of the code - Split server and peer configs - Added PreAuthPeer to handle version handshake + auth step - Added a temporary in-memory KnownPeerStore for auth step - Remember Configs load filepath to re-use on save by default - FileType to/from str/streams - Fix File transfers logic that could sometimes crash
f-michaut
force-pushed
the
styling-client-auth-version-handshake
branch
from
180847a to
fa82bce
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.