-
-
Notifications
You must be signed in to change notification settings - Fork 23.4k
fix: Handle object-type API key in OpenAI Moderation embed #5591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: Handle object-type API key in OpenAI Moderation embed #5591
Conversation
Fixes FlowiseAI#4663 When OpenAI Moderation is used in embedded chat, the API key was being passed as an object instead of a string, causing a 401 error with "[object Object]" being sent to OpenAI's API. Changes: - Updated OpenAIModerationRunner constructor to handle both string and object type API keys - Added type checking to extract the API key from object properties (openAIApiKey, apiKey, or key) - Maintains backward compatibility with string-type API keys This fix ensures moderation works correctly in both internal chat canvas and embedded chat contexts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello @rahulb18, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where OpenAI Moderation failed in embedded chat due to the API key being passed as an object instead of a string. The core change involves enhancing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a bug where the OpenAI API key was being passed as an object in embedded chats, leading to authentication errors. The fix in OpenAIModerationRunner.ts is well-targeted, adding logic to handle an object-based API key by extracting it from a set of possible properties. This ensures moderation works correctly in different contexts while maintaining backward compatibility.
I've provided a couple of suggestions to improve type safety and code clarity in the constructor. One is a minor tweak to the type signature, and the others address a potential type safety issue in the key extraction logic to prevent potential runtime errors from non-string key values.
packages/components/nodes/moderation/OpenAIModeration/OpenAIModerationRunner.ts
Outdated
Show resolved
Hide resolved
packages/components/nodes/moderation/OpenAIModeration/OpenAIModerationRunner.ts
Show resolved
Hide resolved
packages/components/nodes/moderation/OpenAIModeration/OpenAIModerationRunner.ts
Outdated
Show resolved
Hide resolved
…derationRunner.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…derationRunner.ts Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Fixes #4663
When OpenAI Moderation is used in embedded chat, the API key was being passed as an object instead of a string, causing a 401 error with "[object Object]" being sent to OpenAI's API.
Changes:
This fix ensures moderation works correctly in both internal chat canvas and embedded chat contexts.