Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Dec 20, 2025

The current long names are not readable. I've fixed them to match the source codes below:

gmt/src/grdfilter.c

Lines 867 to 883 in 812e370

case 'N': /* Treatment of NaNs */
n_errors += gmt_M_repeated_module_option (API, Ctrl->N.active);
switch (opt->arg[0]) {
case 'i':
Ctrl->N.mode = NAN_IGNORE; /* Default */
break;
case 'r':
Ctrl->N.mode = NAN_REPLACE; /* Replace */
break;
case 'p':
Ctrl->N.mode = NAN_PRESERVE; /* Preserve */
break;
default:
GMT_Report (API, GMT_MSG_ERROR, "Expected -Ni|p|r\n");
n_errors++;
break;
}

Copy link
Member

@joa-quim joa-quim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These must have escaped me in first proposal. They were really bad.

@seisman seisman merged commit 13070fa into master Dec 20, 2025
11 of 13 checks passed
@seisman seisman deleted the grdfilter/long branch December 20, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants