-
Notifications
You must be signed in to change notification settings - Fork 2.9k
feat(functions): upgrade to java25 runtime #10210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
* Compiler Compatibility: The maven.compiler.source and maven.compiler.target properties in pom.xml needed to be updated from 11 to 25.
* Parent Configuration: The shared-configuration parent POM was updated to version 1.2.2 to align with newer Java runtime
samples.
* Plugin Updates: The jacoco-maven-plugin version 0.8.7 does not support Java 25 (major version 69). It was necessary to
explicitly add version 0.8.14 to the pom.xml to resolve build failures during test coverage reporting.
[INFO] ------------------------------------------------------- │
│ [INFO] T E S T S │
│ [INFO] ------------------------------------------------------- │
│ [INFO] Running functions.HelloWorldTest │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.807 s -- in functions.HelloWorldTest │
│ [INFO] │
│ [INFO] Results: │
│ [INFO] │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 │
│ [INFO] │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] BUILD SUCCESS │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] Total time: 9.410 s │
│ [INFO] Finished at: 2025-12-19T09:01:21Z │
│ [INFO] ------------------------------------------------------------------------
Summary of ChangesHello @iennae, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on upgrading the project's build configuration to support Java 25. This involves updating the Java compiler version, aligning the parent POM with newer configurations, and ensuring that essential build plugins, such as Jacoco, are compatible with the new Java runtime. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the Maven-based helloworld function to target the Java 25 runtime. The changes involve updating the parent POM version, setting the Java compiler level to 25, and adding a compatible version of the jacoco-maven-plugin. The changes are clear and well-justified in the description. I have one suggestion to improve the Maven configuration for better build consistency. Additionally, please note that the corresponding Gradle project (functions/helloworld/helloworld-gradle) has not been updated; you might consider updating it as well to maintain consistency.
| <maven.compiler.target>25</maven.compiler.target> | ||
| <maven.compiler.source>25</maven.compiler.source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better build portability and to prevent accidental usage of APIs from a newer JDK than the target, it's recommended to use the <maven.compiler.release> property instead of setting <maven.compiler.source> and <maven.compiler.target> separately. This single property configures both and also sets the correct boot classpath, ensuring your code is truly compatible with the specified Java version.
<maven.compiler.release>25</maven.compiler.release>
[INFO] ------------------------------------------------------- │
│ [INFO] T E S T S │
│ [INFO] ------------------------------------------------------- │
│ [INFO] Running functions.HelloWorldTest │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.807 s -- in functions.HelloWorldTest │
│ [INFO] │
│ [INFO] Results: │
│ [INFO] │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 │
│ [INFO] │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] BUILD SUCCESS │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] Total time: 9.410 s │
│ [INFO] Finished at: 2025-12-19T09:01:21Z │
│ [INFO] ------------------------------------------------------------------------