Skip to content

Conversation

@iennae
Copy link
Contributor

@iennae iennae commented Dec 19, 2025

  • Compiler Compatibility: The maven.compiler.source and maven.compiler.target properties in pom.xml needed to be updated from 11 to 25.
  • Parent Configuration: The shared-configuration parent POM was updated to version 1.2.2 to align with newer Java runtime samples.
  • Plugin Updates: The jacoco-maven-plugin version 0.8.7 does not support Java 25 (major version 69). It was necessary to explicitly add version 0.8.14 to the pom.xml to resolve build failures during test coverage reporting.

[INFO] ------------------------------------------------------- │
│ [INFO] T E S T S │
│ [INFO] ------------------------------------------------------- │
│ [INFO] Running functions.HelloWorldTest │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.807 s -- in functions.HelloWorldTest │
│ [INFO] │
│ [INFO] Results: │
│ [INFO] │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0 │
│ [INFO] │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] BUILD SUCCESS │
│ [INFO] ------------------------------------------------------------------------ │
│ [INFO] Total time: 9.410 s │
│ [INFO] Finished at: 2025-12-19T09:01:21Z │
│ [INFO] ------------------------------------------------------------------------

*  Compiler Compatibility: The maven.compiler.source and maven.compiler.target properties in pom.xml needed to be updated from 11 to 25.
* Parent Configuration: The shared-configuration parent POM was updated to version 1.2.2 to align with newer Java runtime
      samples.
* Plugin Updates: The jacoco-maven-plugin version 0.8.7 does not support Java 25 (major version 69). It was necessary to
      explicitly add version 0.8.14 to the pom.xml to resolve build failures during test coverage reporting.

 [INFO] -------------------------------------------------------                                                            │
│ [INFO]  T E S T S                                                                                                         │
│ [INFO] -------------------------------------------------------                                                            │
│ [INFO] Running functions.HelloWorldTest                                                                                   │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.807 s -- in functions.HelloWorldTest             │
│ [INFO]                                                                                                                    │
│ [INFO] Results:                                                                                                           │
│ [INFO]                                                                                                                    │
│ [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0                                                                   │
│ [INFO]                                                                                                                    │
│ [INFO] ------------------------------------------------------------------------                                           │
│ [INFO] BUILD SUCCESS                                                                                                      │
│ [INFO] ------------------------------------------------------------------------                                           │
│ [INFO] Total time:  9.410 s                                                                                               │
│ [INFO] Finished at: 2025-12-19T09:01:21Z                                                                                  │
│ [INFO] ------------------------------------------------------------------------
@iennae iennae requested review from a team and yoshi-approver as code owners December 19, 2025 09:09
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Dec 19, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iennae, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the project's build configuration to support Java 25. This involves updating the Java compiler version, aligning the parent POM with newer configurations, and ensuring that essential build plugins, such as Jacoco, are compatible with the new Java runtime.

Highlights

  • Java Runtime Upgrade: The project has been upgraded to Java 25 runtime, updating compiler source and target properties from Java 11 to Java 25.
  • Parent POM Update: The shared-configuration parent POM has been updated to version 1.2.2 to align with newer Java runtime samples.
  • Jacoco Plugin Compatibility: The jacoco-maven-plugin was explicitly updated to version 0.8.14 to ensure compatibility with Java 25 and resolve build failures during test coverage reporting.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the Maven-based helloworld function to target the Java 25 runtime. The changes involve updating the parent POM version, setting the Java compiler level to 25, and adding a compatible version of the jacoco-maven-plugin. The changes are clear and well-justified in the description. I have one suggestion to improve the Maven configuration for better build consistency. Additionally, please note that the corresponding Gradle project (functions/helloworld/helloworld-gradle) has not been updated; you might consider updating it as well to maintain consistency.

Comment on lines +53 to +54
<maven.compiler.target>25</maven.compiler.target>
<maven.compiler.source>25</maven.compiler.source>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better build portability and to prevent accidental usage of APIs from a newer JDK than the target, it's recommended to use the <maven.compiler.release> property instead of setting <maven.compiler.source> and <maven.compiler.target> separately. This single property configures both and also sets the correct boot classpath, ensuring your code is truly compatible with the specified Java version.

    <maven.compiler.release>25</maven.compiler.release>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant