Skip to content

Conversation

@krisxcrash
Copy link
Contributor

@krisxcrash krisxcrash commented Dec 16, 2025

Aligned the paystub download icon in the Payroll Overview table to improve visual consistency across different screen sizes.

SDK-198

Changes

  • Desktop/tablet views: Paystub icon is right-aligned in the table column
  • Mobile views: Paystub icon is left-aligned for better touch target accessibility

Implementation

  • Added .paystubIconWrapper CSS class to handle responsive alignment
  • Used the existing container-query mixin with the small breakpoint (40em) to match codebase patterns
  • Wrapped the ButtonIcon component in a flex container for proper alignment control
Screen.Recording.2025-12-16.at.1.46.37.PM.mov

Copy link
Member

@serikjensen serikjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in slack, but the ticket was dealing with adjusting the paystub text to be left aligned so we may be able to simplify!

>
<DownloadIcon />
</ButtonIcon>
<div className={styles.paystubIconWrapper}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we need more generalized approach for these buttons... also, could this class name be applied to ButtonIcon directly, without a wrapper?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did make a change to support consistent action buttons in that dataview pr. Might be worth a look even if we don't merge that one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR based on your design changes @aaronlee777

Copy link
Member

@serikjensen serikjensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! just a couple of things

Comment on lines +14 to +16
@include container-query(map-get($global-breakpoints, 'small')) {
justify-content: flex-end;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is only applied to the desktop view, could we remove this conditional container query styling?

]

const actions = (
<ActionsLayout justifyContent="end">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure we want these buttons filling the container on desktop? Seems on desktop we'd want it to have the previous behavior? Maybe worth checking in with design on that?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants