-
Notifications
You must be signed in to change notification settings - Fork 354
chore: update HTML standards, secure external links, and enforce HTTPS #1792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update HTML standards, secure external links, and enforce HTTPS #1792
Conversation
✅ Deploy Preview for earnest-hotteok-b1e1bf ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
eduardo-rodrigues
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Rudra-Tiwari-codes. This looks good to me but let me ask the confirmation of colleagues @roiser and @graeme-a-stewart as well.
|
Thank you for these little improvements @Rudra-Tiwari-codes. There are now conflicting files after #1793 was merged that had some of the same fixes. Can resolve those conflicts please? |
- Add lang='en' attribute to HTML tags for accessibility - Fix viewport meta tag syntax (add missing comma) - Update HTTP links to HTTPS for security - Add rel='noopener noreferrer' to external links to prevent tabnabbing
d012559 to
9a1969c
Compare
|
Done! |
|
Warning: This author is forking multiple ML projects such as google-deepmind/alphafold, ml-explore/mlx, openai/CLIP, pytorch/pytorch, tensorflow/tensorflow, anthropics/claude-code, vllm-project/vllm, and others, adding minimal "contributions" (often for tests or miscellaneous changes) without proper validation. A review of their commits shows mostly local implementations of TODOs copied from existing projects, with little to no substantive review or testing. So far, this author has forked 41 repositories following the same pattern. Be careful when accepting this PR. It’s also concerning how this author is able to submit PRs across four repositories in the same day, each requiring large context, which strongly suggests a highly automated workflow. |
|
Team, pls, be careful. this author is generating a lot of misc PRs across too many repos. check if the PR is really needed in our project, because this author is only refactoring the source code using LLMs. pls, pay attention to the latest PRs that you already merged into our project |
|
specifically, here is your project. you have a lot of these PRs from this author. I checked the changes, and in some repos they are basically noisy content, or content that only works for LLMs, which you don't need to accept because it is not a real contribution at all, or it's a contribution that you can do yourself using an LLM, and probably better, because you have the real context of the project check this URL to see the PR over this Author: |
|
Thank you for the feedback regarding my recent activity. I am a student and I have been using these smaller tasks as a way to familiarize myself with the architecture of various codebases. I was not aware that submitting multiple minor pull requests was considered disruptive to the maintainer workflow or seen as contribution padding. I appreciate the correction and will pay much closer attention to the impact of my work moving forward. I am closing this pull request now to focus on delivering more substantive technical contributions that provide genuine value to the community. |
Add lang='en' attribute to HTML tags for accessibility
Fix viewport meta tag syntax (add missing comma)
Update HTTP links to HTTPS for security
Add rel='noopener noreferrer' to external links to prevent tabnabbing