Skip to content

Conversation

@LofhJann
Copy link

@LofhJann LofhJann commented Jun 4, 2025

For ADO-42314

@LofhJann LofhJann requested a review from Copilot June 4, 2025 10:42
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request aims to "Improve log levels" by adjusting logging verbosity and removing redundant log filtering.

  • Removed duplicate log filtering configuration from logback.xml
  • Downgraded log levels from info/warn to debug in specific message handling methods

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/resources/logback.xml Removed DuplicateLogFilter to eliminate duplicate log suppression
src/main/java/fi/hsl/transitdata/stopestimates/PubtransStopEstimatesFactory.java Downgraded log level for via point messages from info to debug
src/main/java/fi/hsl/transitdata/stopestimates/MessageHandler.java Adjusted log levels by removing a warn log for unexpected schema and changing metro trip logging to debug
Comments suppressed due to low confidence (4)

src/main/resources/logback.xml:2

  • The removal of DuplicateLogFilter may lead to duplicate log entries. Confirm that this change is fully intentional and that any potential increase in log volume is handled appropriately elsewhere.
<filter class="fi.hsl.transitdata.common.logging.DuplicateLogFilter">

src/main/java/fi/hsl/transitdata/stopestimates/MessageHandler.java:38

  • Removing the warning log for unexpected schema may obscure abnormal behaviors. Confirm that this change is acceptable and that other monitoring mechanisms are in place to capture potential issues.
log.warn("Received unexpected schema, ignoring.");

src/main/java/fi/hsl/transitdata/stopestimates/PubtransStopEstimatesFactory.java:92

  • Ensure that changing the log level from info to debug for via point events aligns with operational monitoring requirements, so that key information does not become too hidden.
log.debug("Event is for a via point, message discarded");

src/main/java/fi/hsl/transitdata/stopestimates/MessageHandler.java:59

  • Switching the metro trip logging from info to debug reduces log verbosity, which is likely intentional. Verify that this does not remove critical diagnostic information needed in production environments.
log.debug("Found metro trip. RouteId: {}", routeId);

@LofhJann
Copy link
Author

LofhJann commented Jun 4, 2025

Duplicate log filter has been removed due to it not working in the first place (dev change, never introduced in production environments) and due to decision that it's not worth fixing at least for now. We're trying to tackle excess logging via other means for now (without losing important information).

@LofhJann LofhJann merged commit 84f08b0 into aks-dev Jun 27, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants