-
Notifications
You must be signed in to change notification settings - Fork 27
Expose connection module #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @douglasdcm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical importability issue within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
Hi, thank you for this contribution. Your change correctly identifies and fixes the issue of the cdp.connection module not being exposed. However, the change is made to an auto-generated file (cdp/__init__.py), which is discouraged as mentioned in the file's header. My review comment provides more detail on this. The fix should be applied to the generator script (generator/generate.py) to make it permanent. Once you've updated the generator, this will be a great addition to the library!
Hi, how are you? I'm following the example from Quick Start, but I'm not able to import
cdp.connection. It seems the root cause is that it is not present in the filecpd.__init__.py. This MR exposes the module.Issue Details
I installed the tool according to the documentation and tried to run the example code, but I was not able to access the
connectionmodule.Module not accessible

After the change
I executed the tests and all of them are passing. I used Python 3.7
pip freeze