Fix mso.verify Add test + add status list variable to integrate status list ref in mso #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o/issuer.py - tests update (replaced revocation to status list for the sake of clarity) Load also Y coordinate from DER certificate instead of calculating it + enhanced some "unit" tests Allow multiple doc support in IS0 18013-5 format Add support to load PEM certificate format (and not only DER ones)
peppelinux
requested review from
PascalDR and
peppelinux
and removed request for
PascalDR
PascalDR
approved these changes
Mar 19, 2025
peppelinux
requested changes
Mar 19, 2025
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
excellent work
I request to use only the parameter cert_path for both DER and PEM formats and to not remove the revocation parameter, as introduced by the european ref impl, only to reduce code misalignment
we look forward to implement the status list package in eudi-wallet-it-python, here:
https://github.com/italia/eudi-wallet-it-python
…parameter set utc in valid from
peppelinux
requested changes
Mar 20, 2025
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
excellent work, two small suggestions about code improvement and cleanup
peppelinux
reviewed
Mar 20, 2025
… more general revocation dict parameter
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
code prevents a useless and costly try/except using a conditional when trying to parse issuer cert Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
peppelinux
approved these changes
Mar 20, 2025
Contributor
Author
|
Giuseppe, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add minimal support to integrate status list reference data in the mso/issuer.py - tests update (replaced revocation to status list for the sake of clarity)
Load also Y coordinate from DER certificate instead of calculating it + enhanced some "unit" tests
Allow multiple doc support in IS0 18013-5 format
Add support to load PEM certificate format (and not only DER ones)